Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow mediation of failed and closed trades #6998

Merged
merged 1 commit into from Jan 14, 2024
Merged

Allow mediation of failed and closed trades #6998

merged 1 commit into from Jan 14, 2024

Conversation

ghost
Copy link

@ghost ghost commented Jan 9, 2024

#6948 results in some pending trades falsely moved to failed. #6996 results in some pending trades falsely moved to closed.

@pazza83 has requested that a dispute ticket initiated from the peer (via the mediator) should open on a client if their trade is pending, closed or failed. The closed or failed trade will be reverted to pending so that the mediation can be processed in a normal manner.

This helps address the non-responding peer issue, as the non-responding peer will get a support ticket notification.

Copy link
Contributor

@alvasw alvasw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

A unlikely edge case, we can ignore for now: The FailedTradesManager could've cleared the sensitive data of a trade (if user manually set it to a low number of days) before the other peer opens mediation.

Copy link
Contributor

@alejandrogarcia83 alejandrogarcia83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alejandrogarcia83 alejandrogarcia83 merged commit 5872e9e into bisq-network:master Jan 14, 2024
3 checks passed
@alejandrogarcia83 alejandrogarcia83 added this to the v1.9.15 milestone Jan 14, 2024
@ghost ghost mentioned this pull request Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants