Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions: Create aggregated JaCoCo coverage report #6719

Conversation

alvasw
Copy link
Contributor

@alvasw alvasw commented May 31, 2023

Supersedes #6689

@alvasw
Copy link
Contributor Author

alvasw commented Jun 1, 2023

Hi @napoly,

Sorry! I didn't want to steal your work or hurt your feelings!

I checked the Gradle documentation when I reviewed your PR, and I was confused that you upgraded Gradle and the shadow library. We usually only update dependencies if we have to (for security reasons) to avoid supply chain attacks. I had to try it myself to see whether the library updates were needed.

I will close my PRs (#6717, #6718, #6719, #6720) [#6720 needs some changes]. Please cherry-pick the commits and re-commit them (to set yourself as the author). This is the first time, I heard about GitHubs co-author feature.

@alvasw alvasw closed this Jun 1, 2023
@alvasw alvasw reopened this Jul 6, 2023
@alvasw alvasw force-pushed the ci_create_aggregated_coverage_report branch from 73af9b3 to d176759 Compare July 6, 2023 15:55
alvasw and others added 2 commits July 6, 2023 18:00
Co-authored-by: napoly <napolytan@protonmail.com>
Co-authored-by: napoly <napolytan@protonmail.com>
@alvasw alvasw force-pushed the ci_create_aggregated_coverage_report branch from d176759 to feca0fb Compare July 6, 2023 16:00
alejandrogarcia83

This comment was marked as outdated.

@alvasw alvasw dismissed alejandrogarcia83’s stale review July 6, 2023 19:25

The merge-base changed after approval.

Copy link
Contributor

@alejandrogarcia83 alejandrogarcia83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alejandrogarcia83 alejandrogarcia83 dismissed their stale review July 6, 2023 19:28

The merge-base changed after approval.

@alejandrogarcia83 alejandrogarcia83 merged commit 5a3283e into bisq-network:master Jul 6, 2023
12 checks passed
@alejandrogarcia83 alejandrogarcia83 added this to the v1.9.13 milestone Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants