Do not use 0 btc outputs #3725
Merged
Do not use 0 btc outputs #3725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes bisq-network#3721 and bisq-network#3722 There are still more issues as such a payout tx will cause that the trade ends up in failed trades. This commit only fixes the invalid tx issue.
If we do not get any BTC from a mediated payout tx we do not know about the confirmation state so it would stay always in the unconfirmed state. To avoid that confusion we prefer to hide the icon. This is a known issue from BitcoinJ but we have not found a solution for that yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ripcurlx Please cherry pick that to the release branch.
Fixes #3721 and #3722 but there are more issues open as a payout with only 1 receiver still cause a trade to end up in failed trades.