Account number label in Swedish fix #3645
Conversation
|
Swedish account validation checks that the account number consists of: 11 or 13 or 15 decimal digits. |
|
@rafaelpac Could you please resolve the conflict with BankUtil and update your commit messages to follow https://chris.beams.io/posts/git-commit/#7-rules - we know that you updated BankUtil.java 😉 . Thanks! |
|
And please squash it into one commit in that case. |
|
Hoping this is the correct way and place to post this bug. When I try to register a new SEPA account (Swedish Skandiabanken), the SAVE NEW ACCOUNT button remains grey and unclickable. No error messages. The same account has worked previously. Running Bisq v. 1.2.3. |
|
@camahama |
|
I'm sorry... I can't find how to change the commit message. I think it is not doable in the web interface, right? |
You have to change your commit history locally and force push your changes to your remote PR branch. |
| @@ -157,9 +157,9 @@ public static String getAccountNrLabel(String countryCode) { | |||
| case "HK": | |||
| return Res.get("payment.accountNr"); | |||
| case "NO": | |||
| return "Kontonummer"; // do not translate as it is used in Norwegian only | |||
| return "Kontonummer"; // do not translate as it is used in norwegian and swedish only | |||
There was a problem hiding this comment.
As it looks like the label is exactly the same I think we could merge those two cases.
@rafaelpac Besides my comment on the cases here is how you squash multiple commits into one locally: https://www.internalpointers.com/post/squash-commits-into-one-git |
|
I'm sorry, I completely forgot about this PR. |
Fixes #3641
According to this issue, the label "Bankgiro number", as it was hardcoded in BankUtil.java, should not be used in Sweden.
The label "Kontonummer" is the correct one to be used in Sweden and Norway.
Account number validation is implemented to Norwegian accounts in AccountNrValidator.java.
There is no validation implemented to Swedish accounts, so nothing to change there.
If account validation for Sweden is needed, a different method would be needed (see Wikipedia reference below):