Trade Info Popup #3329
Closed
Trade Info Popup #3329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue #3317
freimair
suggested changes
Nov 4, 2019
core/src/main/java/bisq/core/payment/payload/PaymentAccountPayload.java
Outdated
Show resolved
Hide resolved
core/src/main/java/bisq/core/payment/payload/PaymentAccountPayload.java
Outdated
Show resolved
Hide resolved
ripcurlx
suggested changes
Nov 5, 2019
core/src/main/java/bisq/core/payment/payload/PaymentAccountPayload.java
Outdated
Show resolved
Hide resolved
ripcurlx
suggested changes
Nov 12, 2019
| @@ -60,8 +61,9 @@ protected void run() { | |||
| failed("Payment method is banned.\n" + | |||
| "Payment method=" + trade.getOffer().getPaymentMethod().getId()); | |||
| } else if (filterManager.isPeersPaymentAccountDataAreBanned(paymentAccountPayload, appliedPaymentAccountFilter)) { | |||
| String paymentDetails = Res.getWithCol("payment.altcoin.sender.address", trade.getOffer().getCurrencyCode()); | |||
There was a problem hiding this comment.
This absolutely wrong it would change the paymentDetails displayed e.g. for MoneyBeam you would replace Res.get(paymentMethodId) + " - " + Res.getWithCol("payment.account") + " " + accountId; with Res.getWithCol("payment.altcoin.sender.address", trade.getOffer().getCurrencyCode());
| @@ -175,9 +179,9 @@ private void addContent() { | |||
| nrOfDisputesAsBuyer + " / " + nrOfDisputesAsSeller); | |||
|
|
|||
| addConfirmationLabelTextFieldWithCopyIcon(gridPane, ++rowIndex, Res.get("shared.paymentDetails", Res.get("shared.buyer")), | |||
| contract.getBuyerPaymentAccountPayload().getPaymentDetails()).second.setMouseTransparent(false); | |||
| buyerPaymentDetails).second.setMouseTransparent(false); | |||
There was a problem hiding this comment.
You are removing the real payment details with e.g. Sender's BTC address
| addConfirmationLabelTextFieldWithCopyIcon(gridPane, ++rowIndex, Res.get("shared.paymentDetails", Res.get("shared.seller")), | ||
| sellerPaymentAccountPayload.getPaymentDetails()).second.setMouseTransparent(false); | ||
| sellerPaymentDetails).second.setMouseTransparent(false); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #3317