Expose size and fix symbol resize issue #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has changed?
symbolImageSizeattribute to control the size from the JS side.Solution Description
This builds on top of #146.
CarPlay has the following recommendation for the symbol size.
However, I wasn't able to achieve the inline Symbol and Instruction(the first one) design by using the
primaryandsecondaryresize options. So, I have exposed a new attributesymbolImageSizeto set the image size. This allows for finer control from the JS side. The calculation for the image size happens on the JS side and takes the scale of the CarPlay window and the image into account.Demo
Previous Implementation
New Implementation
Symbol Image and Instruction in one line
Symbol Image and Instruction on separate line