Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preprocess_species downloads too many files #21

Closed
ethanplunkett opened this issue Mar 1, 2023 · 0 comments · Fixed by #27
Closed

preprocess_species downloads too many files #21

ethanplunkett opened this issue Mar 1, 2023 · 0 comments · Fixed by #27
Assignees
Labels
enhancement New feature or request

Comments

@ethanplunkett
Copy link
Contributor

ebirdst_download() downloads 66 geotiffs for each species - three resolutions each of 22 different datasets.

preprocess_species() should be updated to just download the abundance files (3 datasets) in the resolutions we need (possibly only low res, likely never high res).

For all models start by downloading the low resolution abundance and the spatial metadata and figure out which resolution we are ultimately going to use. Then download the three abundance datasets we use in that resolution.

The spatial metadata is loaded with: ebirdst::load_fac_map_parameters(path = sp_path)

This would speed up fitting of new species and reduce network traffic, especially for the automated CI tests which run frequently.

@ethanplunkett ethanplunkett added the enhancement New feature or request label Mar 1, 2023
@ethanplunkett ethanplunkett self-assigned this Mar 1, 2023
ethanplunkett added a commit that referenced this issue Mar 3, 2023
Only download the files it needs
Improved resolution heuristic
Additional unit and regression tests
Closes #21
@ethanplunkett ethanplunkett linked a pull request Mar 3, 2023 that will close this issue
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant