Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pip install (don't import package at install) #4

Merged
merged 1 commit into from
Nov 1, 2019

Conversation

davidcaron
Copy link

The problem was that the requirements were not installed when running pip install. And we got the error ModuleNotFoundError: No module named 'requests'

@cehbrecht cehbrecht merged commit 838a937 into bird-house:master Nov 1, 2019
@cehbrecht cehbrecht added the bug label Nov 1, 2019
@cehbrecht cehbrecht added this to the 0.4.0 milestone Nov 1, 2019
@cehbrecht
Copy link
Member

@davidcaron thanks for looking at it.

Do you want a new release? But we should move it to Python 3.x ... maybe python 3.x only?

@davidcaron
Copy link
Author

I realized while you were merging it that I was including the quotes in the version number 🤦‍♂ .

As for a new release, for now my workaround is to pip install requests before installing threddsclient, and that works, so it's not a big problem. But a new version of threddsclient would be cleaner, if that's possible.

@cehbrecht
Copy link
Member

@davidcaron sorry ... I didn't check things before. The update patch went to the original ... not to the birdouse fork.

Looks like python 3 is already there. Can I drop python 2.x and release 4.0?

@davidcaron
Copy link
Author

I'm not sure what you mean by "The update patch went to the original"... If I understand correctly, the original ScottWales/threddsclient repo is unmaintained, and you are the only maintainer?

I would personally be fine with a 0.4.0 release dropping python 2.7.

@cehbrecht
Copy link
Member

@davidcaron I got confused :) There is a very old PR at the original threddsclient using the master branch ... that is why I got a notification. Sins of the past ...

@cehbrecht cehbrecht mentioned this pull request Nov 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants