Remove or ignore unused imports (F401) (senaite#2081)

* Remove unused imports (F401)

* Ignore unused imports in exportimport.instruments

* Remove unused imports from browser.viewlets.toolbar

* Remove unused imports from browser.form.adapters.sampletype

* Remove unused imports from browser.fields.record

* Ignore unused imports in behaviors

* Remove unused imports from exportimport.dataimport

* Remove unused imports from exportimport.instruments

* Remove unused imports from numbergenerator

* Remove unused imports from jsonapi

* Ignore unused imports in skins.bika.guard_handler

* Remove unused imports from content.referencesample

* Remove unused imports from content.worksheetfolder

* Remove unused imports from content.bikasetup

* Remove unused imports from content.instrumenttype

* Remove unused imports from content.duplicateanalysis

* Remove unused imports from content.referencedefinition

* Remove unused imports from content.manufacturer

* Remove unused imports from content.report

* Remove unused imports from browser.analysisprofile

* Ignore unused imports in browser.worksheet.views

* Remove unused imports in browser.department.ajax

* Remove unused imports in browser.viewlets.analysisrequest

* Ignore unused imports in browser.analyses

* Remove unused imports in browser.analyses.view

* Ignore unused imports in browser.client

* Ignore unused imports in browser.widgets

* Remove unused imports in browser.widgets.rejectionwidget

* Ignore unused imports in browser.analysisrequest.analysisrequests

* Ignore unused imports in browser.analysisrequest

* Remove unused imports in browser.reports

* Remove unused imports in lims.api.analysis

* Remove unused imports in lims.monkey.Widget

* Ignore unused imports in subscribers

* Ignore unused imports in interfaces

* Enable E712 in flake8

src/bika/lims/api/analysis.py

@@ -28,7 +28,6 @@
 from zope.component._api import getAdapters
 
 from bika.lims.interfaces import IDuplicateAnalysis
-from bika.lims.interfaces import ISubmitted
 from bika.lims.interfaces.analysis import IRequestAnalysis
 
 

src/bika/lims/browser/analyses/view.py

@@ -50,7 +50,6 @@
 from bika.lims.utils import get_image
 from bika.lims.utils import get_link
 from bika.lims.utils import get_link_for
-from bika.lims.utils import getUsers
 from bika.lims.utils import t
 from bika.lims.utils.analysis import format_uncertainty
 from DateTime import DateTime

src/bika/lims/browser/analysisprofile.py

@@ -18,7 +18,6 @@
 # Copyright 2018-2021 by it's authors.
 # Some rights reserved, see README and LICENSE.
 
-from bika.lims.jsonapi import load_field_values
 from bika.lims.interfaces import IJSONReadExtender, IAnalysisProfile
 from zope.component import adapts
 from zope.interface import implements

src/bika/lims/browser/analysisrequest/__init__.py

@@ -34,9 +34,9 @@
 # this comment twice.
 from .view import AnalysisRequestViewView
 
-from .add2 import AnalysisRequestAddView  # noqa: F401
-from .add2 import AnalysisRequestManageView  # noqa: F401
-from .add2 import ajaxAnalysisRequestAddView  # noqa: F401
+from .add2 import AnalysisRequestAddView
+from .add2 import AnalysisRequestManageView
+from .add2 import ajaxAnalysisRequestAddView
 from .analysisrequests import AnalysisRequestsView
 from .invoice import InvoicePrintView
 from .invoice import InvoiceView

src/bika/lims/browser/department/ajax.py

@@ -20,7 +20,6 @@
 
 from Products.CMFCore.utils import getToolByName
 from bika.lims.browser import BrowserView
-import plone
 import json
 
 

src/bika/lims/browser/reports/productivity_analysesperformedpertotal.py

@@ -24,7 +24,6 @@
 from bika.lims.browser import BrowserView
 from bika.lims.browser.reports.selection_macros import SelectionMacrosView
 from plone.app.layout.globals.interfaces import IViewView
-from six import StringIO
 from zope.interface import implements
 
 

src/bika/lims/browser/reports/selection_macros/__init__.py

@@ -24,7 +24,6 @@
 from Products.Five.browser.pagetemplatefile import ViewPageTemplateFile
 from bika.lims.utils import getUsers
 from bika.lims import bikaMessageFactory as _
-from bika.lims import PMF
 from plone.memoize import ram
 from time import time
 

src/bika/lims/browser/viewlets/analysisrequest.py

@@ -23,7 +23,6 @@
 
 from bika.lims import FieldEditSpecification
 from bika.lims import api
-from bika.lims import logger
 from bika.lims.api.analysis import is_result_range_compliant
 from bika.lims.api.security import check_permission
 

src/bika/lims/browser/widgets/rejectionwidget.py

@@ -21,10 +21,7 @@
 from AccessControl import ClassSecurityInfo
 from Products.Archetypes.Registry import registerWidget
 from Products.Archetypes.Widget import TypesWidget
-from Products.Archetypes.interfaces import IVocabulary
-from zope.interface import implements
-from zope.schema.vocabulary import SimpleVocabulary
-from zope.schema.vocabulary import SimpleTerm
+
 try:
     from zope.component.hooks import getSite
 except:

src/bika/lims/browser/worksheet/tools.py

@@ -38,7 +38,7 @@ def checkUserAccess(worksheet, request, redirect=True):
     """
     # Deny access to foreign analysts
     allowed = worksheet.checkUserAccess()
-    if allowed == False and redirect == True:
+    if not allowed and redirect:
         msg =  _('You do not have sufficient privileges to view '
                  'the worksheet ${worksheet_title}.',
                  mapping={"worksheet_title": worksheet.Title()})
@@ -57,7 +57,7 @@ def checkUserManage(worksheet, request, redirect=True):
         /manage_results view. Otherwise, does nothing
     """
     allowed = worksheet.checkUserManage()
-    if allowed == False and redirect == True:
+    if not allowed and redirect:
         # Redirect to /manage_results view
         destination_url = worksheet.absolute_url() + "/manage_results"
         request.response.redirect(destination_url)

src/bika/lims/content/bikasetup.py

@@ -58,7 +58,6 @@
 from Products.Archetypes.utils import IntDisplayList
 from Products.Archetypes.Widget import RichWidget
 from Products.CMFCore.utils import getToolByName
-from senaite.core import registry as senaite_registry
 from senaite.core.api import geo
 from senaite.core.browser.fields.records import RecordsField
 from senaite.core.interfaces import IHideActionsMenu

src/bika/lims/content/duplicateanalysis.py

@@ -28,7 +28,6 @@
 from bika.lims.content.abstractroutineanalysis import schema
 from bika.lims.content.analysisspec import ResultsRangeDict
 from bika.lims.interfaces import IDuplicateAnalysis
-from bika.lims.interfaces import ISubmitted
 from bika.lims.interfaces.analysis import IRequestAnalysis
 from bika.lims import logger
 from bika.lims.workflow import in_state

src/bika/lims/content/instrumenttype.py

@@ -20,9 +20,6 @@
 
 from AccessControl import ClassSecurityInfo
 from Products.Archetypes.public import *
-from Products.CMFCore.permissions import View, ModifyPortalContent
-from bika.lims import bikaMessageFactory as _
-from bika.lims.utils import t
 from bika.lims.config import PROJECTNAME
 from bika.lims.content.bikaschema import BikaSchema
 from bika.lims.interfaces import IInstrumentType, IDeactivable

src/bika/lims/content/manufacturer.py

@@ -20,9 +20,6 @@
 
 from AccessControl import ClassSecurityInfo
 from Products.Archetypes.public import *
-from Products.CMFCore.permissions import View, ModifyPortalContent
-from bika.lims import bikaMessageFactory as _
-from bika.lims.utils import t
 from bika.lims.config import PROJECTNAME
 from bika.lims.content.bikaschema import BikaSchema
 from bika.lims.interfaces import IManufacturer, IDeactivable

src/bika/lims/content/referencedefinition.py

@@ -22,16 +22,12 @@
     reference samples used in quality control
 """
 from AccessControl import ClassSecurityInfo
-from DateTime import DateTime
 from Products.Archetypes.public import *
-from Products.CMFCore.permissions import View, ModifyPortalContent
 from bika.lims.content.bikaschema import BikaSchema
 from bika.lims.browser.fields import ReferenceResultsField
 from bika.lims.browser.widgets import ReferenceResultsWidget
 from bika.lims.config import PROJECTNAME
-import sys
-import time
-from bika.lims import PMF, bikaMessageFactory as _
+from bika.lims import bikaMessageFactory as _
 from bika.lims.interfaces import IDeactivable
 from zope.interface import implements
 

src/bika/lims/content/referencesample.py

@@ -21,9 +21,6 @@
 """ReferenceSample represents a reference sample used for quality control testing
 """
 
-import sys
-import time
-
 from AccessControl import ClassSecurityInfo
 from bika.lims import api
 from bika.lims import bikaMessageFactory as _

src/bika/lims/content/report.py

@@ -23,13 +23,10 @@
 from DateTime import DateTime
 from Products.Archetypes.public import *
 from plone.app.blob.field import FileField as BlobFileField
-from Products.CMFCore.utils import getToolByName
 from bika.lims.content.bikaschema import BikaSchema
 from bika.lims.config import PROJECTNAME
 from bika.lims import bikaMessageFactory as _
 from bika.lims.content.clientawaremixin import ClientAwareMixin
-from bika.lims.utils import t
-from bika.lims.browser import ulocalized_time
 from bika.lims.utils import user_fullname
 
 schema = BikaSchema.copy() + Schema((

src/bika/lims/content/worksheetfolder.py

@@ -22,15 +22,11 @@
 """
 from Products.ATContentTypes.content import schemata
 from Products.Archetypes import atapi
-from Products.CMFCore import permissions
-from Products.CMFCore.utils import getToolByName
 from bika.lims.config import PROJECTNAME
 from bika.lims.interfaces import IWorksheetFolder
 from plone.app.folder import folder
 from AccessControl import ClassSecurityInfo
 from zope.interface import implements
-from bika.lims import bikaMessageFactory as _
-from bika.lims.utils import t
 
 schema = folder.ATFolderSchema.copy()
 schema['id'].widget.visible = {'edit':'hidden', 'view': 'invisible'}

src/bika/lims/jsonapi/getusers.py

@@ -18,14 +18,12 @@
 # Copyright 2018-2021 by it's authors.
 # Some rights reserved, see README and LICENSE.
 
-from bika.lims.utils import getUsers
 from plone.jsonapi.core import router
 from plone.jsonapi.core.interfaces import IRouteProvider
 from Products.CMFCore.utils import getToolByName
 from zExceptions import BadRequest
 from zope import interface
-import json
-import transaction
+
 
 class getUsers(object):
     interface.implements(IRouteProvider)

src/bika/lims/jsonapi/read.py

@@ -19,7 +19,7 @@
 # Some rights reserved, see README and LICENSE.
 
 from Products.CMFPlone.utils import safe_unicode
-from bika.lims import logger, to_utf8
+from bika.lims import logger
 from bika.lims.interfaces import IJSONReadExtender
 from bika.lims.jsonapi import get_include_fields
 from plone.jsonapi.core import router

src/bika/lims/jsonapi/remove.py

@@ -18,13 +18,11 @@
 # Copyright 2018-2021 by it's authors.
 # Some rights reserved, see README and LICENSE.
 
-from bika.lims.jsonapi.read import read
 from plone.jsonapi.core import router
 from plone.jsonapi.core.interfaces import IRouteProvider
 from Products.CMFCore.utils import getToolByName
 from zExceptions import BadRequest
 from zope import interface
-import json
 import transaction
 
 

src/bika/lims/monkey/Widget.py

@@ -22,7 +22,6 @@
 from bika.lims import logger
 from bika.lims.interfaces import IATWidgetVisibility
 from types import DictType
-from plone import api
 from Acquisition import aq_base
 from zope.component import getAdapters
 

src/bika/lims/numbergenerator.py

@@ -20,12 +20,10 @@
 
 import thread
 import logging
-import datetime
 from bika.lims.interfaces import INumberGenerator
 from BTrees.OIBTree import OIBTree
 from plone import api
 from zope.annotation.interfaces import IAnnotations
-from zope.component import getGlobalSiteManager
 from zope.interface import implements
 
 

src/senaite/core/browser/fields/record.py

@@ -18,15 +18,11 @@
 # Copyright 2018-2021 by it's authors.
 # Some rights reserved, see README and LICENSE.
 
-from types import ClassType
 from types import DictType
-from types import FileType
-from types import IntType
 from types import ListType
 from types import StringType
 from types import StringTypes
 from types import TupleType
-from types import UnicodeType
 
 from AccessControl import ClassSecurityInfo
 from App.class_init import InitializeClass
@@ -42,7 +38,6 @@
 from Products.CMFCore.Expression import createExprContext
 from Products.CMFCore.utils import getToolByName
 from Products.PythonScripts.standard import html_quote
-from senaite.core.browser.fields.utils import getDisplayList
 from senaite.core.browser.widgets.recordwidget import RecordWidget
 
 # we have to define our own validation handling

src/senaite/core/browser/form/adapters/sampletype.py

@@ -1,7 +1,5 @@
 # -*- coding: utf-8 -*-
 
-from bika.lims import api
-from bika.lims import senaiteMessageFactory as _
 from senaite.core.browser.form.adapters import EditFormAdapterBase
 from bika.lims.vocabularies import getStickerTemplates
 

src/senaite/core/exportimport/dataimport.py

@@ -19,12 +19,9 @@
 # Some rights reserved, see README and LICENSE.
 
 import json
-import os.path
 
-from pkg_resources import resource_filename
 from pkg_resources import resource_listdir
 
-import plone
 from bika.lims.browser import BrowserView
 from bika.lims.interfaces import ISetupDataSetList
 from plone.app.layout.globals.interfaces import IViewView

src/senaite/core/exportimport/instruments/alere/pima/__init__.py

@@ -20,9 +20,6 @@
 
 """ Alere Pima
 """
-from datetime import datetime
-from bika.lims.utils import to_unicode
-from bika.lims import bikaMessageFactory as _
 from senaite.core.exportimport.instruments.resultsimport import \
     AnalysisResultsImporter, InstrumentCSVResultsFileParser
 

src/senaite/core/exportimport/instruments/biodrop/ulite/__init__.py

@@ -20,11 +20,8 @@
 
 """ Biodrop
 """
-from bika.lims import bikaMessageFactory as _
-from bika.lims.utils import t
 from senaite.core.exportimport.instruments.resultsimport import \
     InstrumentCSVResultsFileParser, AnalysisResultsImporter
-from datetime import datetime
 
 class BioDropCSVParser(InstrumentCSVResultsFileParser):
     """

src/senaite/core/exportimport/instruments/eltra/cs/__init__.py

@@ -23,7 +23,6 @@
 from datetime import datetime
 from senaite.core.exportimport.instruments.resultsimport import \
     AnalysisResultsImporter, InstrumentCSVResultsFileParser
-from bika.lims import bikaMessageFactory as _
 
 
 class EltraCSTSVParser(InstrumentCSVResultsFileParser):

src/senaite/core/exportimport/instruments/facscalibur/calibur/__init__.py

@@ -20,7 +20,6 @@
 
 """ Facs Calibur
 """
-from datetime import datetime
 from senaite.core.exportimport.instruments.resultsimport import \
     AnalysisResultsImporter, InstrumentCSVResultsFileParser
 

src/senaite/core/exportimport/instruments/facscalibur/calibur/model_e9750.py

@@ -26,7 +26,6 @@
 from . import FacsCaliburCSVParser, FacsCaliburImporter
 import json
 import traceback
-import logging
 
 title = "FACS Calibur"
 

src/senaite/core/exportimport/instruments/foss/winescan/__init__.py

@@ -20,8 +20,6 @@
 
 """ FOSS 'Winescan'
 """
-from bika.lims import bikaMessageFactory as _
-from bika.lims.utils import t
 from senaite.core.exportimport.instruments.resultsimport import \
     InstrumentCSVResultsFileParser, AnalysisResultsImporter
 

src/senaite/core/exportimport/instruments/lifetechnologies/qubit/__init__.py

@@ -21,8 +21,6 @@
 """ Life Technologies QuBit
 """
 from datetime import datetime
-from bika.lims.utils import to_unicode
-from bika.lims import bikaMessageFactory as _
 from senaite.core.exportimport.instruments.resultsimport import \
     AnalysisResultsImporter, InstrumentCSVResultsFileParser
 

src/senaite/core/exportimport/instruments/panalytical/omnia/__init__.py

@@ -22,7 +22,6 @@
 """
 from datetime import datetime
 from bika.lims.utils import to_unicode
-from bika.lims import bikaMessageFactory as _
 from senaite.core.exportimport.instruments.resultsimport import \
     AnalysisResultsImporter, InstrumentCSVResultsFileParser
 

src/senaite/core/exportimport/instruments/sealanalytical/aq2/__init__.py

@@ -20,7 +20,6 @@
 
 """ Seal Analytics AQ2
 """
-from datetime import datetime
 from senaite.core.exportimport.instruments.resultsimport import \
     AnalysisResultsImporter, InstrumentCSVResultsFileParser
 

src/senaite/core/exportimport/instruments/tescan/tima/__init__.py

@@ -20,8 +20,6 @@
 
 """ Tescan TIMA
 """
-from bika.lims import bikaMessageFactory as _
-from bika.lims.utils import t
 from senaite.core.exportimport.instruments.resultsimport import \
     InstrumentCSVResultsFileParser, AnalysisResultsImporter
 from datetime import datetime

src/senaite/core/exportimport/instruments/tescan/tima/tima.py

@@ -21,8 +21,6 @@
 """ TESCAN TIMA
 """
 from . import TimaCSVParser, TimaImporter
-from senaite.core.exportimport.instruments.resultsimport import \
-    AnalysisResultsImporter
 import json
 import traceback