Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: presets for cubi-tk sodar ingest-fastq (#232 ) #235

Conversation

Nicolai-vKuegelgen
Copy link
Contributor

No description provided.

@Nicolai-vKuegelgen Nicolai-vKuegelgen linked an issue Aug 19, 2024 that may be closed by this pull request
Copy link
Contributor

Please format your code with black: make black.

Copy link
Contributor

@tedil tedil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor remarks, otherwise LGTM

cubi_tk/sodar/ingest_fastq.py Outdated Show resolved Hide resolved
cubi_tk/sodar/ingest_fastq.py Show resolved Hide resolved
cubi_tk/sodar/ingest_fastq.py Outdated Show resolved Hide resolved
tests/test_sodar_ingest_fastq.py Outdated Show resolved Hide resolved
Copy link
Contributor

@tedil tedil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nicolai-vKuegelgen Nicolai-vKuegelgen merged commit 8669118 into main Sep 2, 2024
4 checks passed
@Nicolai-vKuegelgen Nicolai-vKuegelgen deleted the 232-enhance-cubi-tk-sodar-ingest-fastq-with-regex-presets branch September 2, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance cubi-tk sodar ingest-fastq with (regex) presets
2 participants