Add auto-detect On-board SD Card via M115 and change PRINT_CANCEL_GCODE behaviour to be sent only when printing from TFT's SD card #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
guruathwal
commented
Apr 27, 2020
•
guruathwal
commented
- With this update, the TFT firmware will be able to auto-detect Onboard SD Card with M115 starting from Marlin Bugfix 2.0.x date: 2020-04-27.
- Enable PRINT_CANCEL_GCODE by default and change PRINT_CANCEL_GCODE behaviour to be sent only when printing from TFT's SD card and USB flash disk to avoid duplicate Cancel G-codes when printing from Onboard SD card.
Enable PRINT_CANCEL_GCODE by default and change PRINT_CANCEL_GCODE behaviour to be sent only when printing from TFT's SD card and USB flash disk to avoid duplicate Cancel G-codes when printing from Onboard SD card.
guruathwal
changed the title
This was referenced Apr 30, 2020
|
Nice! |
Merged
jeffeb3
pushed a commit
to jeffeb3/BIGTREETECH-TouchScreenFirmware
that referenced
this pull request
Jul 20, 2020
…DE behaviour to be sent only when printing from TFT's SD card (bigtreetech#627) Enable PRINT_CANCEL_GCODE by default and change PRINT_CANCEL_GCODE behaviour to be sent only when printing from TFT's SD card and USB flash disk to avoid duplicate Cancel G-codes when printing from Onboard SD card.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.