Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ Update Actions versions #2918

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

thisiskeithb
Copy link
Contributor

@thisiskeithb thisiskeithb commented Mar 16, 2024

Description

  • Update Actions to latest versions because most are using Node.js 20 now due to Node.js 16 being deprecated. See GitHub Blog - GitHub Actions: Transitioning from Node 16 to Node 20 for more information.

  • Update to Python 3.9

  • lock-threads Action replaced lock-threads-app "Application", so lock.yml is no longer needed. It doesn't look like the LockBot ever ran here though, so this will be a new feature 😄

  • Limit stale Action to this repo (bigtreetech/BIGTREETECH-TouchScreenFirmware) like what is done for other Actions.

@bigtreetech bigtreetech merged commit a6ef076 into bigtreetech:master Mar 25, 2024
1 check passed
@thisiskeithb thisiskeithb deleted the pr/update_actions branch March 25, 2024 03:03
@digant73
Copy link
Contributor

digant73 commented Mar 26, 2024

@thisiskeithb do you know why stale is not applied also to PR? I mean, all the current PRs are older than 60 days but they were not yet marked as stale.

@thisiskeithb
Copy link
Contributor Author

do you know why stale is not applied also to PR? I mean, all the current PRs are older than 60 days but they were not yet marked as stale.

@digant73: They're not stale. kisslorand continues to keep them updated. They need at least 60 days of zero activity to be marked as stale & then no comments/changes after another 7 days for them to be closed.

image

@digant73
Copy link
Contributor

digant73 commented Mar 26, 2024

strange, maybe you see his activities in his repo but I do not see any activity since more than 4 months on this repo so I was expecting that the PRs were marked as stale

@thisiskeithb
Copy link
Contributor Author

strange, maybe you see his activities in his repo but I do not see any activity since more than 4 months on this repo so I was expecting that the PRs were marked as stale

I grabbed that screenshot from this repo's PR queue: https://github.com/bigtreetech/BIGTREETECH-TouchScreenFirmware/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-desc

Just let the bot do its thing 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants