Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨 CI fixes: Bump Checkout to V3, use Python 3.7 and update README Badges #2862

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

thisiskeithb
Copy link
Contributor

@thisiskeithb thisiskeithb commented Nov 6, 2023

Description

  • CI fixes:
    • Bump Checkout to V3
    • Use Python 3.7
  • Update badges in README:
    • Link to License
    • Use last commit as release date and link to master.zip
    • Fix Build Binary CI badge

Note: The Build Binaries action will run after the next PR merge/commit since the .github folder & *.md files are excluded.

Benefits

PR checks & build binary scripts will work again.

Related Issues

None. Noticed that CI tasks were broken again.

@thisiskeithb thisiskeithb changed the title 🔨 CI fixes: Bump Checkout to V3, use Python 3.7 🔨 CI fixes: Bump Checkout to V3, use Python 3.7 and update README Badges Nov 6, 2023
- Link to License
- Use last commit as release date and link to master.zip
- Fix Build Binary CI badge
@thisiskeithb
Copy link
Contributor Author

@kisslorand: You should wait to push parts of this PR into your pending PRs since it is not merged and can lead to conflicts.

Once this is merged, rebase your PRs on top of the latest master commit and these changes will be brought in automatically.

@bigtreetech bigtreetech merged commit 08119fd into bigtreetech:master Nov 7, 2023
1 check passed
@thisiskeithb thisiskeithb deleted the pr/fix_gh_actions branch November 7, 2023 00:55
@digant73
Copy link
Contributor

@thisiskeithb I see that the bot to mark as stale an Issue or PR after 60 days of inactivity is also not working (so they will never be closed after the configured 7 days). It should be useful to fix that issue if possible. Issues can be marked as resolved by a PR and so automatically closed when the PR is merged but this is not applicable to PRs. Currently there are 14 zombie PRs that should be closed

@thisiskeithb
Copy link
Contributor Author

thisiskeithb commented Feb 29, 2024

@thisiskeithb I see that the bot to mark as stale an Issue or PR after 60 days of inactivity is also not working (so they will never be closed after the configured 7 days). It should be useful to fix that issue if possible. Issues can be marked as resolved by a PR and so automatically closed when the PR is merged but this is not applicable to PRs.

The stale bot that BigTreeTech uses has shut down, so they'll need to migrate to actions/stale.

Currently there are 14 zombie PRs that should be closed

That isn't up to me.

@digant73
Copy link
Contributor

digant73 commented Feb 29, 2024

yes, sure it wasn't you. I meant that if you know/could fix also that issue it should be good.

EDIT: Just fixed in #2903

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants