Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unnecessary cache queue for managing PLR feature #2820

Merged
merged 13 commits into from
Oct 31, 2023

Conversation

digant73
Copy link
Contributor

@digant73 digant73 commented Jul 23, 2023

IMPROVEMENTS:

  • Removed unnecessary cache queue for managing PLR feature: Standard command queue is enough to handle PLR. The removal of cache queue allowed to reduce more than 2200 bytes of memory:
  • Improved error handling on PowerFailed API: Operations on files (e.g. file closure) and status variables are managed to allow a proper cleanup in any scenario (e.g. error on file opening, file reading etc...)
  • loopProcessToCondition() function integrated on TASK_LOOP_WHILE macro: loopProcessToCondition renamed to loopProcessAndGUI and integrated on TASK_LOOP_WHILE macro allowing any conditional loop to handle both background and GUI interactions avoiding any sort of loop deadlock
  • Added error handling on Comment API: Added error handling on Comment API to avoid possible access to NULL pointer tokens causing unexpected crashes/freezes/strange behavior during a print. Applying what is good (old implementation of API) on PR 2701 not going to be merged. All credits to kisslorand
  • Minor cleanup on VFS API. Partially applying what is good in 2817 avoiding to reintroduce 2 bugs already provided by users, already fixed and explained. All credits to kisslorand
  • Minor clean up, code optimization and reduction

BUGFIXES:

  • Fixed wrong icon displayed on Notification menu: icon was set after the popup window was already displayed

PR STATE: Ready for merge

@bigtreetech bigtreetech merged commit c59153a into bigtreetech:master Oct 31, 2023
1 check passed
kisslorand pushed a commit to kisslorand/BIGTREETECH-TFT that referenced this pull request Nov 6, 2023
kisslorand pushed a commit to kisslorand/BIGTREETECH-TFT that referenced this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants