Remove SERIAL_FLOAT_PRECISION Requirement #2812
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marlin will not report a temperature with more than two digits beyond the decimal place since it uses _MIN(SERIAL_FLOAT_PRECISION, 2) for temperature reporting and 2 will always be less than 4.
|
This may get fixed upstream, so I'm going to close this for now: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Marlin will not report a temperature or position with more than two digits beyond the decimal place since it uses
_MIN(SERIAL_FLOAT_PRECISION, 2)for temperature reporting and 2 will always be less than 4. Other values printed via serial are now hard-coded to use one or two digits.Benefits
Removes unnecessary Marlin config change.
Related Issues
None. Discovered while working through other serial issues in Marlin.