Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes on top of last merged PRs #2768

Merged
merged 4 commits into from
Apr 17, 2023

Conversation

digant73
Copy link
Contributor

@digant73 digant73 commented Apr 11, 2023

BUG FIXES:

  • Fixed instability bug introduced by Safer alternatives for "strncpy" #2662: despite the safety code claimed by Safer alternatives for "strncpy" #2662, the changes applied by that PR (use of strxcpy() function) made the code unsafe. strxcpy is not applicable at all in VFS API where the source buffer's size is always less that the destination buffer's size. strxcpy is not safe in general, meaning an out of buffer read occurs when the source buffer's size is less than the destination buffer's size (as in VFS API). Also strwcpy() and strscpy() were not working (freeze or wrong displayed files navigating on sd card/usb stick). Proper functions named strncpy_pad()/strncpy_no_pad() are now used
  • Fixed instability bug provided by setPrintTitle() function (in Printing menu): the hideExtension()/restoreExtension() functions made visible on VFS API by Safer alternatives for "strncpy" #2662 are not applicable on a standard string buffer. Those functions are specific to manage the data defined in the API (they have been hided also for that reason). Previous code is restored
  • No new mesh applied by MeshEdit menu: with the changes applied by Mesh Editor - Overhaul #2737 the meshSetValue() function is now setting the mesh for the original mesh instead of the mesh value provided by MeshTuner menu. It means that none of the meshes set by MeshTuner menu is applied at all. Furthermore, pressing on save button the original data grid was restored instead of setting the current data grid as the new original data grid
  • Fixed unmatching function declaration/definition in .h/.c introduced by Babystep reset fix #2654: Fixed babystepSetValue() signatures
  • Other bug fixes: e.g. wrong check on BedLeveling menu introduced by FW size reduction & bugfixes #2766

NOTE: #2766 removed the CaseLightControl API properly created (as any other API) to decouple the GUI from the core functions (e.g. the that API was used in interfaceCmd API). Now, a return to the past (3 years ago) has been applied

PR STATE: ready for merge

@rondlh
Copy link

rondlh commented Apr 14, 2023

Merged and tested OK, seems like an important fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants