Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and replace some icons & ASCII font for TFT24/28 #2249

Merged
merged 4 commits into from
Nov 18, 2021

Conversation

guruathwal
Copy link
Contributor

@guruathwal guruathwal commented Nov 15, 2021

  • Replace the unlicensed/copyrighted delta calibration icon.
  • Rename 'calibration.bmp' to 'delta_calibrate.bmp'
  • Update corner/manual levelling icons.
  • Remove duplicate marlin mode icon and add touch mode icon.
  • update ASCII font for TFT24/28 to be slightly taller and easy to read.

@radek8
Copy link
Contributor

radek8 commented Nov 15, 2021

You can look at the icons marlin.bmp a marlin_mode.bmp?
These two icons could be merged into one. It is an unnecessary waste of space on two icons with the same meaning.

@guruathwal
Copy link
Contributor Author

Yes that makes sense. I will change it.

@radek8
Copy link
Contributor

radek8 commented Nov 16, 2021

Round icons (touch_mode and marlin_mode) updated in PR # 2251

Was there a license problem on the Delta icon? Will it be necessary to fix the round delta icon?

@guruathwal
Copy link
Contributor Author

guruathwal commented Nov 17, 2021

Yes, it should be fixed as the icon is not licensed to be used here.

@guruathwal guruathwal changed the title Update and replace some icons Update and replace some icons & ASCII font for TFT24/28 Nov 17, 2021
@digant73
Copy link
Contributor

digant73 commented Nov 17, 2021

good you updated fonts for TFT24/28. Many people (one of that it's me) had problems reading in particular some letters/numbers (e.g. 0 very similar to 6 and 8). At the end, I only lost about 1 diopter :-)

@kisslorand
Copy link
Contributor

kisslorand commented Nov 17, 2021

The update of the ASCII fonts for 2.4" and 2.8" TFT is highly welcomed. In some places the text position should be lowered a bit (2-3) pixels to be vertically centered (one such place would be the status screen).

@bigtreetech bigtreetech merged commit b16e63f into bigtreetech:master Nov 18, 2021
digant73 added a commit to digant73/BIGTREETECH-TouchScreenFirmware that referenced this pull request Nov 18, 2021
@guruathwal guruathwal deleted the PR15-11 branch December 2, 2021 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants