ExtrusionMenu-Load/UnLoadToMoreMenu

[kisslorand]

Requirements

BTT TFT or MKS TFT

Description

• added Load/Unload menu to "More" menu during print (replaces Terminal which can be also found under More -> Machine menu)
• "Extrusion" menu overhauled (preheat option if nozzle too cold, "Heat" button instead of "Nozzle" if only one nozzle, question about cooling down when leaving the menu)
• during print Pause, no question about cooling when exiting Load/Unload or Extrusion menu
• Load/Unload button moved to Mainmenu and Extrusion button moved to Move menu, following @mehmetsutas's logic
• rearranged Move menu items

Related Issues

Fixes #1423

RAM & Flash impact

RAM ->0 bytes extra
Flash -> 304 bytes extra

[thisiskeithb]

There's now a GitHub action that will automatically compile & replace existing firmware binaries after a PR is merged or changes are committed directly to the master branch, so those are no longer needed and can be removed.

[Codel1417]

There's now a GitHub action that will automatically compile & replace existing firmware binaries after a PR is merged or changes are committed directly to the master branch, so those are no longer needed and can be removed.

My action didn't previously check what repo it was generating binaries for, just the master branch.

[thisiskeithb]

My action didn't previously check what repo it was generating binaries for, just the master branch.

The PR source wasn't from master, so I assumed they were added manually.

[kisslorand]

I never work on the master branch, I always create a new branch for every idea, fix, etc. The bin files were generated automatically by VSCode.
I made a commit with the bin files deleted but they still show up in github.

[oldman4U]

kisslorand

I guess you are not using the gcode file preview and therefore you do not care even a little bit how this affects other users which are using this function. But you can not change the firmware the way you would like it, without taking a bit care of others. Why you are not making a private version, where you can do whatever you want?

[kisslorand]

kisslorand

I guess you are not using the gcode file preview and therefore you do not care even a little bit how this affects other users which are using this function. But you can not change the firmware the way you would like it, without taking a bit care of others. Why you are not making a private version, where you can do whatever you want?

@oldman4U
Beg your pardon?! I do not care??? 80% of my work is bugfix and requested features implementation. Thank you!
What have I done this time? How could I upset you adding a feature without removing anything???
Anyway, I know, no good deed remains unpunished.

Later edit: somehow I had a feeling you will jump at my throat with this PR, I was very eager what would you find this time

[oldman4U]

You added great things to the firmware and you fixed some painful issues, nobody wanted to fix. But you also removed existing features, just because you did not need it and you wanted to force your own solution.

So in addition to the Back button which opens the same window you get when you press the Print button on the main screen, there is now also a button labeled BabyStep, showing the preview of the printed element.

I wish you would see the benefit of working together, instead of doing what you believe is right, because it works for you.

[Codel1417]

@oldman4U is this an in progress design?

[oldman4U]

The design is available for all pages of the TFT35 resolution using 480x320. From this point on it is math to adjust it for other resolutions. What's missing from my side are the buttons itself for all resolutions. Gurmeet started with the implementation but has no time anymore. The first step is to remove the echo window from the main screen and to add the lower bar. To be able to remove the echo window he added the ability to see the last three echo notifications in an extra window which is the button in the lower left corner. This is where it stopped.;-(

[kisslorand]

One thing more. I am not ill and I am also not drunken, but I have another opinion than you. I would prefer to keep this conversation on a respectful level. Thank you

I am glad to hear your health is in a good shape and you are sober. No one asked about your health nor nobody said that you are drunk but it's nice that you shared with us your well-being. (Please do not put words in my mouth I never said, it's disgusting.)
How ironic is that the same person who started to throw mud and spitting on me asks for respect...
I asked multiple times what is wrong with this PR so I can fix it. You were so respectful that you didn't care the slightest amount to explain what's bothering you with this PR. It was more comfortable to spit more. Yeah, you really are the definition of respect itself.

I am asking again, what is wrong with this PR? Please provide that detail so I can fix it.

kisslorand

I guess you are not using the gcode file preview and therefore you do not care even a little bit how this affects other users which are using this function. But you can not change the firmware the way you would like it, without taking a bit care of others. Why you are not making a private version, where you can do whatever you want?

What is this "respectful level" all about? What are you even talking about? It is addressed directly to me, accusing me about something that I do not have the slightest clue. Would you please show us how respectful is your level and explain what have I done in this PR and how do I "do not care even a little bit how this affects other users which are using this function"?
The screenshot you provided was like that when I first installed this FW to my TFT, before I made any PR.
So, again, what is that awful thing I've done?

Babystep, file preview with babystep label, Back were there during print since I first installed this FW to my TFT. Babysteps and More were removed in a later PR but only AFTER print is finished. As @mehmetsutas mentioned:
"Having links to babystep and more menus are useless. When print is finished what can a user do on those menus. Also you say you should design for dumbest user, so users should not have such an option."

I haven't tested THIS PR but the current build and my experience with you is, that it does not matter where and when I write you something, but that you do your thing without looking left or right. And I ask myself where this will end.

Yeah, you haven't tested it but it must be wrong because it is made by me. Your sought respect is bursting with abundance.

In case you missed (again) my request, please explain what is wrong in this PR so I can fix it. Please let me know the awful thing done in this PR that led you to cover me with such an amount of filth.

[digant73]

@kisslorand please on extrude.c apply your changes starting from my file in my PR. I changed some indentation.

@oldman4U Overall it seems to me this PR simply makes the load/unload menu available during a print without sacrifacing other features. So it is should be ok. If babystep or other features were removed, I will be the first one asking to revert the changes

[kisslorand]

@digant73
Is it PR #1459? If yes, than it's done.

[digant73]

Yes it is. Good

[kisslorand]

So, after the circus where @oldman4U "respectfully" showed us his true colors by his pointless piss contest out of the blue, things can move on to some beautiful prints.

If no one else (than @You_Know_Who) finds any problem with this PR, it can be merged peacefully.

P.S.: NO, the things introduced in this PR are NOT user selectable, there is NO adjustable thing in config.ini nor in parameters settings. There's NO popup, there's NO info that can/could/should be seen from "a certain distance". Nothing was removed, it's an extra that you can use if you wish or not, that's the only option.

[oldman4U]

Following the advice of a good friend, I will not stretch this even further. But maybe others want to know what kind of person you are.

Regarding ill-founded. Please see #1359
Regarding respectful behaviour: "Alcohol maybe? I never saw him this incoherent..."

@digant73 Thank you for checking. It is all good.

[kisslorand]

Regarding respectful behaviour: "Alcohol maybe? I never saw him this incoherent..."

Would you care to explain? How is mentioning alcohol a lack of respect?
I was trying to find an excuse for your charade.

Following the advice of a good friend, I will not stretch this even further. But maybe others want to know what kind of person you are.

Good excuse to not explain what is your issue with this PR, women style.

Regarding ill-founded. Please see #1359

Would you care to explain? I cannot find anything similar to what you did.
You just cannot stop bashing, can you?

[oldman4U]

So you are also a sexist....

[kisslorand]

Yes, I prefer women. :) The truth is I love them .

[oldman4U]

For all of you reading this.

I am really sorry

[kisslorand]

Yeah, you should!

kisslorand

I guess you are not using the gcode file preview and therefore you do not care even a little bit how this affects other users which are using this function. But you can not change the firmware the way you would like it, without taking a bit care of others. Why you are not making a private version, where you can do whatever you want?

You are very active but still failing to explain what is your issue with this PR. This can make people wonder.
It's getting awkward for your image, isn't it?

[Codel1417]

i hope when btt gets around to reviewing this after they accept/reject the pr the comments are locked

[kisslorand]

It will not stop Herr You_Know_Who to spit on me in the future.

[kisslorand]

@bigtreetech

This is ready to be merged, no bugs related to this PR were reported nor found.