Layer update during printing

[kisslorand]

Requirements

BTT TFT or MKS TFT

Description

Layer update during printing was broken due to PR #1272

Benefits

Layer display during printing fixed. It shows the actual layer height, it updates during printing.

Related Issues

Fixes this issue: #1314

[oldman4U]

Hi.

Why would you change the event to MKS_32_V1_4?

[oldman4U]

And I believe you have a typo, you write "Targetl" but I believe it should be "Target" and suddenly the compiling which failed before also works.

[kisslorand]

Hi.

Why would you change the event to MKS_32_V1_4?

I keep forgetting to set it back to original before making a commit. MKS_32_V1_4 is what I use for my builds.

And I believe you have a typo, you write "Targetl" but I believe it should be "Target" and suddenly the compiling which failed before also works.

Yup, there was a typo.

New commit is on the way, hope it fixes layer update during print issues for BOARD_SD, TFT_USB and TFT_SD gcode file source.

[oldman4U]

👍🏻 kisslorand <notifications@github.com> schrieb am Di. 1. Dez. 2020 um 14:36:

…

Hi. Why would you change the event to MKS_32_V1_4? I keep forgetting to set it back to original before making a commit. MKS_32_V1_4 is what I use for my builds. And I believe you have a typo, you write "Targetl" but I believe it should be "Target" and suddenly the compiling which failed before also works. Yup, there was a typo New commit is on the way, hope it fixes layer update during print issues for BOARD_SD, TFT_USB and TFT_SD gcode file source. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1319 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AM6XKZGENG4OIMZE6TLVNPDSSTWPRANCNFSM4UIJXHAA> .

[mehmetsutas]

👍🏻

I was just making the same change and saw this. :)

[kisslorand]

Does it work with these changes with SD onboard? I can test it only with SD and USB connected to the TFT.

[mehmetsutas]

Maybe on line 278 we should put the coordinatequery call in ternary if also. If it is not printing from BOARD_SD, we do not need to call coordinatequery frequently.

[kisslorand]

Why do you need it when printing from BOARD_SD?

Answering my own question... to find out the "Z:". :)

Actually I watched terminal while printing from TFT_USB and I didn't see a single M114 sent to Marlin. In the PrintingMenu.c I also see no point using it at all while printing from a media attached to the TFT.
How about this in line 278:
if (infoFile.source == BOARD_SD) coordinateQuery();

[mehmetsutas]

@kisslorand that was exactly what I would do.

[oldman4U]

How can I test the code with all PRs failing to check successfully?

[kisslorand]

I guess you can check the changes made and do that to your files locally than build it. How did you do it before?

[mehmetsutas]

I am not able to check it right now. But all changes are reasonable. If it can compile, it should work.

[oldman4U]

I guess you can check the changes made and do that to your files locally than build it. How did you do it before?

This works with just a few changes. I use GitHub Desktop to merge PRs to my local repository.

[oldman4U]

off topic

@mehmetsutas Have you got a mail from me yesterday?