Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the ReadMe to cover the new language.ini, added "The Round Miracle" and the "Hybrid Red" themes and removed the "Classic" theme #1251

Merged
merged 13 commits into from
Nov 27, 2020

Conversation

oldman4U
Copy link
Contributor

@oldman4U oldman4U commented Nov 15, 2020

The new language.ini works different than it is described in the ReadMe today, which could confuse the user.
Added information about the cabling, because there are some users which do not understand how many cables to connect.

I removed the Classic menu, because it is not supported by the last firmware and added two themes which are supporting all TFTs from 24 to 70.

resolves #896
resolves #1175

Added the information, that the config.ini has to be added to the SD card, for a successful firmware update.
@AntoszHUN
Copy link
Contributor

The new language.ini works different than it is described in the ReadMe today, which could confuse the user.
Added information about the cabling, because there are some users which do not understand how many cables to connect.

I removed the Classic menu, because it is not supported by the last firmware and added two themes which are supporting all TFTs from 24 to 70.

resolves #896
resolves #1175

Then now it will be good hopefully! Thanks for all the help and work! As soon as it is included, I will update the icons because I see case_light.bmp is not included. This needs to be remedied urgently.

@oldman4U
Copy link
Contributor Author

Hope so too😁

Can you sent me the missing icons so I add them to this PR. Who knows when btt pushes PRs again.

@AntoszHUN
Copy link
Contributor

Hope so toogrin

Can you sent me the missing icons so I add them to this PR. Who knows when btt pushes PRs again.

Here you go. I didn't know how to send it. But you can download it from here. :)

All TFT new icon.zip

@oldman4U
Copy link
Contributor Author

Done. Please check.

@AntoszHUN
Copy link
Contributor

Done. Please check.

Okay. Super. Thanks!

@Acenotass
Copy link
Contributor

Hello @oldman4U
Thanks for your work! It makes sense to update the preview of my theme with the latest changes (colored bars ), as well as add the rounded corners info. You also need to remove the MSK folder from my theme in your repository.

@oldman4U
Copy link
Contributor Author

Round Miracle Main Screen

Hope this is OK now. Other things will come with next update

@Acenotass
Copy link
Contributor

Perfect!

@oldman4U
Copy link
Contributor Author

Update in 5min

Please check again.

Thank you

@Acenotass
Copy link
Contributor

Acenotass commented Nov 16, 2020

As far as I understand MSK TFT is the same size as the TFT24/28 screen. In this case, IconPack from TFT24/28 should be suitable.

@oldman4U
Copy link
Contributor Author

No idea, but we did not call it BTT TFT only, so hopefully people know what to use. I am not gonna buy MKS hardware to test it, but a TFT43 last week only for testing...

@Acenotass
Copy link
Contributor

@AntoszHUN hi!
Your IconPack lacks tune_extruder.bmp, there are outdated images s_load.bmp, s_save.bmp and extrude_100.bmp. For compliance, I recommend checking with the list from the file \TFT\src\User\API\icon_list.inc

@AntoszHUN
Copy link
Contributor

@AntoszHUN hi!
Your IconPack lacks tune_extruder.bmp, there are outdated images s_load.bmp, s_save.bmp and extrude_100.bmp. For compliance, I recommend checking with the list from the file \TFT\src\User\API\icon_list.inc

@oldman4U
I'll fix it as soon as I know. I attached tune_extruder.bmp. Downloadable. I think oldman4U can do it. I would like to delete the files s_load.bmp, s_save.bmp and extrude_100.bmp. Thanks for the help!

By: AntoszHUN
tune_extruder All TFT.zip

@oldman4U
Copy link
Contributor Author

Hi.

So there is one new icon and in exchange I have to delete the 3 files s_load.bmp, s_save.bmp and extrude_100.bmp.

Correct?

@oldman4U
Copy link
Contributor Author

Please check and let me know in case you find something else.

@Acenotass
Copy link
Contributor

Acenotass commented Nov 17, 2020

Hi.

So there is one new icon and in exchange I have to delete the 3 files s_load.bmp, s_save.bmp and extrude_100.bmp.

Correct?

Yes. Correct.

@AntoszHUN
Copy link
Contributor

Super. Thanks for the help!

@oldman4U
Copy link
Contributor Author

Yesterday after committing, everything was fine, now suddenly there are conflicts.... Is this because of the PR which was merged a few hours ago?

@oldman4U
Copy link
Contributor Author

oldman4U commented Nov 17, 2020 via email

@Acenotass
Copy link
Contributor

1 Copy to SD Card root directory to update (root) - includes .BIN .INI
2 Themes (subfolder root) - Unified Menu Material , The Round Miracle, Hybrid Red
3 Language Packs (subfolder root)- languages .INI

@oldman4U
Copy link
Contributor Author

OK, so the language packs are part of the current Theme folders, so I keep it as it is and will see if they get updated through the language script made by Gurmeet or not. We will see.

For me this PR is ready to be merged in case you do not find anything new.

@ETE-Design
Copy link

@oldman4U I have an MKS TFT28, and there is "no" need for a special folder... But people who own a MKS TFT 28 have to add an directory called MKS on their SD-Card, and copy BMP + FONT to that folder... And they also need th rename the *.bin to mkstft28.bin for it to work...

@oldman4U
Copy link
Contributor Author

oldman4U commented Nov 17, 2020 via email

@ETE-Design
Copy link

@oldman4U Now that MKS TFT28 has it's own Compile Target, should it then still be added to the Readme?

@oldman4U
Copy link
Contributor Author

I have no such TFT, so I can not really speak for users using it. What would you suggest?

@AntoszHUN
Copy link
Contributor

I don’t think MKS TFT displays should have been mixed in. The firmware on it works on a completely different principle. Closed source in addition. I messed with them that year. There's no point in dealing with it in my opinion. Stay with BTT. It's smarter and more functional. But this is just my opinion. I don't want to hurt anyone. :)

AntoszHUN

@oldman4U
Copy link
Contributor Author

I agree, but the same time I do not want to decide this.

In general I am wondering why there are so many MKS and Sidewinder customers. Are the corresponding companies are not offering any help/updates?

@ETE-Design
Copy link

ETE-Design commented Nov 18, 2020

@oldman4U Think there are many Artillery users here cause it is possible to use BBT Firmware on the Stock Sidewinder X1/Genuis... The Firmware delivered with the screen dosen't offer many features... And Artillery choosed to Clone the MKS TFT 28 on their printers...
Have an Sidewinder X1, and the BBT Firmware work great at it, but again it is not the BBT Community's assignment to make it work with that screen... I'm just glad it does :-) Think there is almost if not noone develop firmware for the TFT on Artillery's Printers...
Now that BigTreeTech has merged the #1246 the development for that exact screen should continue?
The funny thing is, I don't see any changes from the MKS 32 already merged... And they didn't even make it compile the file so it will work direct on the screen... You still have to rename the file to mkstft28.bin, but mabye someone could look into that?

@oldman4U
Copy link
Contributor Author

Could "someone" be you?

I help wherever I can, but not having the hardware limits my possibilities and I will not buy the hardware, just to be able to give support - like I do with some of the TFTs I bought.

Someone has to take over, otherwise it will end up like the Classic Interface Theme.

@ETE-Design
Copy link

@oldman4U I'm really not into programmeng :-( But seems like I only need to figure out how to remove "Version" it add to the filename....
Why should you also just but TFT's just to help develop if it dosen't have your interest :-D

@oldman4U
Copy link
Contributor Author

I am no. Developer too so I try to help otherwise.

Hope BTT merges this PR soon. Many annoying tickets are coming in because of the outdated firmware and documentation.

@AntoszHUN
Copy link
Contributor

I am no. Developer too so I try to help otherwise.

Hope BTT merges this PR soon. Many annoying tickets are coming in because of the outdated firmware and documentation.

I'm already looking forward to the merger.

@oldman4U
Copy link
Contributor Author

oldman4U commented Nov 21, 2020 via email

@oldman4U
Copy link
Contributor Author

@bigtreetech @Msq001

This is now the third time that I have to resolve conflicts because you are not merging my commit. Please let me know if you would like to have further commits from me, or not.

Thank you

@bigtreetech
Copy link
Owner

merged now. so sorry for the delay.

@oldman4U
Copy link
Contributor Author

Thank you.

Your inability to show a minimum engagements results in people going away from you.

@bigtreetech
Copy link
Owner

I'm sorry to make you tired. I will invest time in this project. And pay attention to bugs and FR list

@bigtreetech bigtreetech merged commit 2f3f930 into bigtreetech:master Nov 27, 2020
@oldman4U
Copy link
Contributor Author

We the community will take care for the tickets which are coming in, but we need your help for those things we can not do and this is most important to merge PRs. The Bot installed by Gurmeet already closes unused and useless tickets, the centralised FR and hopefully soon centralised Bug list helps to organise the important Bugs and FR's.

For you ToDo:

  1. Please merge Add send gcode check #1255 as soon as possible
  2. Please pin [BUG] Verified Bugs and Known Issues #1218 instead of [FR] [ST7920_Simulator.c] Add a character generator in order to use klipper #290 and change the order of the pinned tickets like described:
    Please make ticket 1218 the most left, followed by the FR ticket [FR] Feature Request List #1170 and the Read Me Before Posting [FAQ] Read me before posting a New Issue! #1047 the one most to the right. This would place it right above the button to start a "New issue" which would make it more likely that people read it.
  3. readek8 will update the Update BIN files #1265 with the PR from today, please update it once available

I believe it is time to release a new version. In case you let us know how this works - we can do it.

Thank you

@AntoszHUN
Copy link
Contributor

@bigtreetech @oldman4U @Msq001

Thank you so much for your help! Also thank you for joining! I am very glad that a Hungarian (I) designed icon pack has been included. That means a lot to me!

Thanks! Respect!
AntoszHUN

@bigtreetech
Copy link
Owner

For you ToDo:

  1. Please merge Add send gcode check #1255 as soon as possible
  2. Please pin [BUG] Verified Bugs and Known Issues #1218 instead of [FR] [ST7920_Simulator.c] Add a character generator in order to use klipper #290 and change the order of the pinned tickets like described:
    Please make ticket 1218 the most left, followed by the FR ticket [FR] Feature Request List #1170 and the Read Me Before Posting [FAQ] Read me before posting a New Issue! #1047 the one most to the right. This would place it right above the button to start a "New issue" which would make it more likely that people read it.
  3. readek8 will update the Update BIN files #1265 with the PR from today, please update it once available

@oldman4U Hello,
for 3. I have updated the precompiled firmware, and clean up the structure of the precompiled folder.
for 2. It's ok now
for 1. #1255 It was submitted by my colleagues, but it has not passed the stress test, so it has not been merged yet. I will merge it after the test is completed

@oldman4U
Copy link
Contributor Author

This is GREAT!

Thank you

This is all for now, I will update the ReadMe asap, so it reflects the new structure.

You made many users very happy today, I really appreciate

@oldman4U
Copy link
Contributor Author

oldman4U commented Nov 27, 2020 via email

jeffeb3 pushed a commit to V1EngineeringInc/BIGTREETECH-TouchScreenFirmware that referenced this pull request Nov 10, 2021
…racle" and the "Hybrid Red" themes and removed the "Classic" theme (bigtreetech#1251)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BIGTREETECH TFT35 V2.0 BITMAPS MISSING ISSUE IN NON-UNIFIED UPDATE Folder upload
5 participants