Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] (Add an option to block the screen on a marlin or graphic mode, remove the switch mode) #1945

Closed
devildant opened this issue May 23, 2021 · 10 comments · Fixed by #2073
Closed
Labels
enhancement New feature or request

Comments

@devildant
Copy link

Describe the solution you'd like
add an options for completely disable the switch mode, to stay in the default mode and no longer be able to change mode

@devildant devildant added the enhancement New feature or request label May 23, 2021
@oldman4U
Copy link
Contributor

How would you leave this mode in touchscreen mode and Marlin mode?

@radek8
Copy link
Contributor

radek8 commented May 23, 2021

This is a big advantage of this display and you want to cancel it?

@devildant
Copy link
Author

devildant commented May 24, 2021

@radek8 I bought a TFT35 E3 V3, for two things, changing the text color and the idle function.

I never use the touchscreen (it's not even connected to my cm because, it doesn't support it anyway)
in this kind of case the switch is useless

@oldman4U the goal is never to leave marlin mode (for motherboards that don't support graphic mode)

I have for the moment made the modification dirty, by commenting the loopCheckMode in MarlinMode.c

   #if LCD_ENCODER_SUPPORT
      sendEncoder(LCD_ReadTouch());

       if (LCD_BtnTouch(LCD_BUTTON_INTERVALS))
         sendEncoder(1);
    #endif
    // disable swith menu 
    // loopCheckMode();

@oldman4U
Copy link
Contributor

You found a good solution for you. All others can simply avoid to press the encoder for more than one second. This helps to avoid switching the mode. I had the problem the other way around and also found a solution.

image

@radek8
Copy link
Contributor

radek8 commented May 24, 2021

@radek8 I bought a TFT35 E3 V3, for two things, changing the text color and the idle function.

I never use the touchscreen (it's not even connected to my cm because, it doesn't support it anyway)
in this kind of case the switch is useless

@oldman4U the goal is never to leave marlin mode (for motherboards that don't support graphic mode)

I have for the moment made the modification dirty, by commenting the loopCheckMode in MarlinMode.c

   #if LCD_ENCODER_SUPPORT
      sendEncoder(LCD_ReadTouch());

       if (LCD_BtnTouch(LCD_BUTTON_INTERVALS))
         sendEncoder(1);
    #endif
    // disable swith menu 
    // loopCheckMode();

Your solution is good.
I doubt that there will be anyone else who bought a touch screen and would like to disable touch mode ...

@radek8
Copy link
Contributor

radek8 commented May 24, 2021

You found a good solution for you. All others can simply avoid to press the encoder for more than one second. This helps to avoid switching the mode. I had the problem the other way around and also found a solution.

image

I've always wondered why you disassembled the encoder :-)

@oldman4U
Copy link
Contributor

Removed the reset the same time. ;-)

@devildant
Copy link
Author

@oldman4U I also removed the reset button, too dangerous

so i will close my feature request, at worst if someone needs it my changes are there

digant73 added a commit to digant73/BIGTREETECH-TouchScreenFirmware that referenced this issue Jul 29, 2021
@oldman4U
Copy link
Contributor

Update. Seems digant73 implemented it in his last PR.

Happy printing

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants