Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Shuttle to use new Queue. #1037

Closed
bigeasy opened this issue Sep 10, 2019 · 0 comments
Closed

Update Shuttle to use new Queue. #1037

bigeasy opened this issue Sep 10, 2019 · 0 comments
Assignees
@bigeasy
Labels
enhancement
Milestone
Refactor IPC.

Comments

@bigeasy
Copy link
Owner

bigeasy commented Sep 10, 2019

Update the Shuttle to use the new Queue. Send the version using the new Queue.version() method.
@bigeasy bigeasy added this to the Refactor IPC. milestone Sep 10, 2019
@bigeasy bigeasy self-assigned this Sep 10, 2019
bigeasy pushed a commit that referenced this issue Sep 11, 2019
@flatheadmill
Fix unit test on Linux.
61dc0c4 
Shuttle test failed because `Shuttle` sets the logging sink and
`Watcher` was logging that a check sum failed (a file had been deleted.)
Not sure why `Watcher` was even attempting to read the file, but I fixed
the test by returning a slice of the gathered messages, instead of
turning the gathered messages.

See #1037.
bigeasy pushed a commit that referenced this issue Sep 11, 2019
@flatheadmill
Revert fix to unit test.
1dc8ba8 
Now that Prolific Watcher logs through its `EventEmitter` super class we
no longer have to be defensive about the logs written to Prolific Sink.

See #1037.
bigeasy pushed a commit that referenced this issue Sep 11, 2019
@flatheadmill
Release Prolific Shuttle 25.0.0-alpha.0.
8343c16 
 * Update Shuttle to use new Queue. Closes #1037.
 * Use `unref` on shuttle socket. Closes #1018.
 * Single entry for processor version update. See #1023.
 * Remove dependency on Prolific Chunk.

Closes #1043.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bigeasy bigeasy

Labels
enhancement
Projects
None yet
Milestone
Refactor IPC.
Development

No branches or pull requests
1 participant
@bigeasy