Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TypeScript and Autocomplete support #100

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

cory-gottschalk
Copy link

What?

Adds support for TypeScript type checking and code editor autocompletion

Tickets / Documentation

Typescript Documentation
Visual Studio Code IntelliSense Documentation

Screenshots

default-autocomplete

api-autocomplete

api-cart autocomplete

hooks-autocomplete

tools-autocomplete

Add typescript definitions for TypeScript and Code Editors
@bigbot
Copy link

bigbot commented Apr 10, 2019

Autotagging @bigcommerce/storefront-team

Cory Gottschalk added 2 commits April 10, 2019 16:24
- adds a type definition for the getItemGiftWrappingOptions method
- adds a type definition for the submitItemGiftWrappingOption method
- updates the callback type in the submitShippingQuote type definition
- makes the errors array optional on the ApiStatusResponse interface
@cory-gottschalk
Copy link
Author

ping @junedkazi

@junedkazi
Copy link
Contributor

@cory-arcticleaf thank you for your contribution. I am not familiar with typescript so give me a couple of days to look into it.

@cory-gottschalk
Copy link
Author

@junedkazi no problem, I'm always happy to contribute! That sounds fine to me, just let me know.

Also, I noticed that the @bigcommerce/storefront-team tag points to a page that doesn't exist. I'm not sure if that's intentional, but I figured I'd let you know so it was on your radar.

@junedkazi
Copy link
Contributor

@cory-arcticleaf yes since the team is internal to the org you won't be able to access the list of members as part of the team. But do use it to get visibility across the storefront team at Bigcommerce.

@cory-gottschalk
Copy link
Author

@junedkazi Sounds good, will do!

@steve-ross
Copy link

been a couple of days 😁

@bigbot
Copy link

bigbot commented Jul 8, 2021

Autotagging @bigcommerce/themes-team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants