feat(common): LFG-177 corrects IDOR #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes a security issue whereby an attacker could use insecure direct object referencing (IDOR). Previously, it was possible to pass another store's hash as a query param to an API endpoint in the app. This would have permitted access to another store's data - so long as that store had installed the app and belonged to the same storefront.
Why?
Security assessment flagged IDOR.
Testing / Proof
Confirmed by requesting
/api/productswith an external, incorrectly signed JWT. Verified on BigCommerce by installing, loading, and uninstalling the app; established production build and TypeScript by running npm run build. Linting and unit tests also ran.@bigcommerce/api-client-developers