fix(core): user is not redirected to Login page after requesting password reset link #979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Ignored Deployments
|
🦋 Changeset detectedLatest commit: 029dbb1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
bc-yevhenii-buliuk
force-pushed
the
fix-login-redirect
branch
from
7470b1f
to
47f06b1
Compare
bc-yevhenii-buliuk
force-pushed
the
fix-login-redirect
branch
from
47f06b1
to
9722526
Compare
bc-yevhenii-buliuk
force-pushed
the
fix-login-redirect
branch
from
9722526
to
415d36c
Compare
bc-yevhenii-buliuk
force-pushed
the
fix-login-redirect
branch
from
415d36c
to
b9f81be
Compare
bc-yevhenii-buliuk
force-pushed
the
fix-login-redirect
branch
from
b9f81be
to
e8b5ebc
Compare
bc-yevhenii-buliuk
force-pushed
the
fix-login-redirect
branch
from
e8b5ebc
to
aed44b7
Compare
bc-yevhenii-buliuk
force-pushed
the
fix-login-redirect
branch
from
aed44b7
to
4e1a384
Compare
bc-yevhenii-buliuk
force-pushed
the
fix-login-redirect
branch
from
4e1a384
to
d38b7d3
Compare
bc-yevhenii-buliuk
force-pushed
the
fix-login-redirect
branch
from
21ba605
to
96c6d68
Compare
bc-yevhenii-buliuk
force-pushed
the
fix-login-redirect
branch
from
96c6d68
to
88256db
Compare
bc-yevhenii-buliuk
force-pushed
the
fix-login-redirect
branch
from
88256db
to
0bee278
Compare
bc-yevhenii-buliuk
force-pushed
the
fix-login-redirect
branch
from
0bee278
to
07827e7
Compare
bc-yevhenii-buliuk
changed the title
bc-yevhenii-buliuk
force-pushed
the
fix-login-redirect
branch
from
07827e7
to
c93deb1
Compare
bc-yevhenii-buliuk
force-pushed
the
fix-login-redirect
branch
from
c93deb1
to
6bcbc5d
Compare
|
To redirect to the Login, I used the context that was created for the Account, so as not to create a separate context for the Login. Guys, do you think this approach is acceptable in this case? If so, should we move this context out of the Account directory and rename it to something more generic to use for both Account and Login? thanks! |
bc-yevhenii-buliuk
requested review from
yurytut1993,
a team and
bc-alexsaiannyi
and removed request for
a team and
yurytut1993
chanceaclark
approved these changes
Jun 17, 2024
|
Some functional tests would be good with this PR as well 🙏 |
bc-yevhenii-buliuk
force-pushed
the
fix-login-redirect
branch
from
6bcbc5d
to
ab89aef
Compare
yurytut1993
approved these changes
Jun 18, 2024
bc-yevhenii-buliuk
force-pushed
the
fix-login-redirect
branch
from
ab89aef
to
029dbb1
Compare
⚡️🏠 Lighthouse reportLighthouse ran against https://catalyst-latest-835frybbc-bigcommerce-platform.vercel.app 🖥️ DesktopWe ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:
📱 MobileWe ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why?
This PR fixes the flow of redirecting users to the Login Page after changing the password
Testing
locally
before:
redirect_flow_1_prev.mov
redirect_flow_2_prev.mov
after:
redirect_flow_1.mov
redirect_flow_2.mov