Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add loading state to remove coupon code button #974

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

jorgemoya
Copy link
Contributor

What/Why?

Noticed it had no loading state.

Testing

Locally.

@jorgemoya jorgemoya requested a review from a team as a code owner June 3, 2024 18:50
Copy link

vercel bot commented Jun 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2024 6:55pm
5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) Visit Preview Jun 3, 2024 6:55pm
catalyst-au ⬜️ Ignored (Inspect) Visit Preview Jun 3, 2024 6:55pm
catalyst-ppr ⬜️ Ignored (Inspect) Visit Preview Jun 3, 2024 6:55pm
catalyst-test-store ⬜️ Ignored (Inspect) Visit Preview Jun 3, 2024 6:55pm
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Jun 3, 2024 6:55pm

Copy link

changeset-bot bot commented Jun 3, 2024

🦋 Changeset detected

Latest commit: 93b3677

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/catalyst-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jun 3, 2024

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-kkcqxsw78-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟢 Performance 100
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 90

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 98
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 92

@jorgemoya jorgemoya added this pull request to the merge queue Jun 3, 2024
Merged via the queue into main with commit 970651c Jun 3, 2024
12 checks passed
@jorgemoya jorgemoya deleted the loading-state-remove-coupon-code branch June 3, 2024 19:47
@github-actions github-actions bot mentioned this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants