Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): custom 404 page not rendering #957

Merged
merged 1 commit into from
May 30, 2024
Merged

fix(core): custom 404 page not rendering #957

merged 1 commit into from
May 30, 2024

Conversation

deini
Copy link
Member

@deini deini commented May 30, 2024

What/Why?

Fixes an issue with our custom 404 page not being used.

Testing

CI

Closes: #956

Copy link

changeset-bot bot commented May 30, 2024

🦋 Changeset detected

Latest commit: a0c7d55

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/catalyst-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented May 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2024 4:56pm
catalyst-ppr ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2024 4:56pm
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) May 30, 2024 4:56pm
catalyst-au ⬜️ Ignored (Inspect) May 30, 2024 4:56pm
catalyst-test-store ⬜️ Ignored (Inspect) May 30, 2024 4:56pm
catalyst-uk ⬜️ Ignored (Inspect) May 30, 2024 4:56pm

Copy link
Contributor

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-enwxqvdld-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟢 Performance 100
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 90

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 98
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 92

@deini deini marked this pull request as ready for review May 30, 2024 16:58
@deini deini requested a review from a team as a code owner May 30, 2024 16:58
@deini deini added this pull request to the merge queue May 30, 2024
Merged via the queue into main with commit 0a3b519 May 30, 2024
15 checks passed
@deini deini deleted the 404 branch May 30, 2024 17:02
@github-actions github-actions bot mentioned this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not Found Page (404) is showing nextjs's default error page
3 participants