Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): update icons on the account page #941

Merged
merged 1 commit into from
May 23, 2024

Conversation

bc-yevhenii-buliuk
Copy link
Contributor

@bc-yevhenii-buliuk bc-yevhenii-buliuk commented May 21, 2024

What/Why?

This PR fixes icons border width on the Account Page

Testing

locally

before:
1846_bug

after:
1846_fix

@bc-yevhenii-buliuk bc-yevhenii-buliuk requested a review from a team as a code owner May 21, 2024 18:55
Copy link

vercel bot commented May 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2024 9:34am
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) Visit Preview May 23, 2024 9:34am
catalyst-au ⬜️ Ignored (Inspect) Visit Preview May 23, 2024 9:34am
catalyst-test-store ⬜️ Ignored (Inspect) Visit Preview May 23, 2024 9:34am
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview May 23, 2024 9:34am

Copy link

changeset-bot bot commented May 21, 2024

🦋 Changeset detected

Latest commit: 1cfb8a2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/catalyst-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jorgemoya
Copy link
Contributor

Since this is an open source repo, please refrain from including any links to internal resources. 🙏

@jorgemoya
Copy link
Contributor

Thanks for fixing this! 👍

Copy link
Contributor

@bc-alexsaiannyi bc-alexsaiannyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@yurytut1993 yurytut1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Copy link
Contributor

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-8glmv4at0-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟢 Performance 100
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 90

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 99
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 92

@bc-yevhenii-buliuk bc-yevhenii-buliuk added this pull request to the merge queue May 23, 2024
Merged via the queue into main with commit 19a3d14 May 23, 2024
11 checks passed
@bc-yevhenii-buliuk bc-yevhenii-buliuk deleted the fix-account-icons branch May 23, 2024 09:40
This was referenced May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants