refactor: move command config closer to action #935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
🦋 Changeset detectedLatest commit: 08e4be1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
matthewvolk
force-pushed
the
refactor/colocate-actions
branch
from
2ec0567
to
e4a2c45
Compare
⚡️🏠 Lighthouse reportLighthouse ran against https://catalyst-latest-poqsks7pg-bigcommerce-platform.vercel.app 🖥️ DesktopWe ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:
📱 MobileWe ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:
|
matthewvolk
force-pushed
the
refactor/colocate-actions
branch
from
e4a2c45
to
892ff3b
Compare
matthewvolk
force-pushed
the
refactor/colocate-actions
branch
from
892ff3b
to
cc560b1
Compare
matthewvolk
force-pushed
the
refactor/colocate-actions
branch
from
cc560b1
to
7743760
Compare
matthewvolk
force-pushed
the
refactor/colocate-actions
branch
from
7743760
to
08e4be1
Compare
christensenep
approved these changes
May 20, 2024
This was referenced May 20, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why?
Tip
It's easier to review this PR without whitespace
This PR doesn't change any functionality, it simply moves a command's (e.g.,
create) configuration and action handler into the same file, cleaning up the main entry point file (index.ts). This removes the awkward exported types we had previously, and now types are inferred automatically by the action handler.Testing