Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unnecessary lint command from cli #921

Merged
merged 1 commit into from
May 17, 2024

Conversation

matthewvolk
Copy link
Contributor

What/Why?

Since the core folder is running with the same ESLint config as scaffolded projects, we no longer need to run the lint task as part of the create-catalyst create command

Testing

Remove lint step in CLI locally and test against --gh-ref=main

@matthewvolk matthewvolk requested a review from a team as a code owner May 17, 2024 18:54
Copy link

vercel bot commented May 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 6:54pm
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) May 17, 2024 6:54pm
catalyst-au ⬜️ Ignored (Inspect) May 17, 2024 6:54pm
catalyst-test-store ⬜️ Ignored (Inspect) May 17, 2024 6:54pm
catalyst-uk ⬜️ Ignored (Inspect) May 17, 2024 6:54pm

Copy link

changeset-bot bot commented May 17, 2024

🦋 Changeset detected

Latest commit: 2ba48e5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/create-catalyst Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-dufj4vyfi-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟢 Performance 100
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 90

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 96
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 92

@matthewvolk matthewvolk added this pull request to the merge queue May 17, 2024
Merged via the queue into main with commit e093e7c May 17, 2024
11 checks passed
@matthewvolk matthewvolk deleted the refactor/remove-lint-cli branch May 17, 2024 18:58
@github-actions github-actions bot mentioned this pull request May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants