Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fetch checkout redirect url with gql #910

Merged
merged 1 commit into from
May 14, 2024
Merged

Conversation

deini
Copy link
Member

@deini deini commented May 13, 2024

What/Why?

  • Removes fetchCartRedirectUrls from client
  • Fetches checkout redirect with new gql node
  • Renames query getCart -> CartPageQuery, forgot to change it during fragment colocation

Testing

  • Locally added products to my cart and proceeded to checkout.
  • CI tests

Copy link

vercel bot commented May 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 8:29pm
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) Visit Preview May 13, 2024 8:29pm
catalyst-au ⬜️ Ignored (Inspect) Visit Preview May 13, 2024 8:29pm
catalyst-test-store ⬜️ Ignored (Inspect) Visit Preview May 13, 2024 8:29pm
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview May 13, 2024 8:29pm

Copy link

changeset-bot bot commented May 13, 2024

🦋 Changeset detected

Latest commit: e7b4a59

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@bigcommerce/catalyst-client Minor
@bigcommerce/catalyst-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-1oxrs4uki-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟢 Performance 99
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 90

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 99
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 92

@deini deini marked this pull request as ready for review May 13, 2024 21:05
@deini deini requested a review from a team as a code owner May 13, 2024 21:05
@BC-krasnoshapka
Copy link
Contributor

@deini seems it was last usage of admin REST API. are you going to cleanup adminApiHostname and token variables in separate PR?

@bc-alexsaiannyi
Copy link
Contributor

seems it was last usage of admin REST API. are you going to cleanup adminApiHostname and token variables in separate PR?

@BC-krasnoshapka I think we have 2 more REST methods in use here, so it's little bit too early for cleanup 🤔

@BC-krasnoshapka
Copy link
Contributor

Sorry, never mind then.

@deini deini added this pull request to the merge queue May 14, 2024
Merged via the queue into main with commit d0352c0 May 14, 2024
11 checks passed
@deini deini deleted the deini/gql-checkout-redirect branch May 14, 2024 15:01
This was referenced May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants