Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): header overflow in mobile widths, remove search when small #875

Merged
merged 1 commit into from
May 7, 2024

Conversation

jorgemoya
Copy link
Contributor

What/Why?

Fix overflow and truncate text if title is too long. Remove search icon when viewport is very small to prevent truncation.

Testing

Screenshot 2024-05-07 at 3 57 53 PM

@jorgemoya jorgemoya requested a review from a team as a code owner May 7, 2024 21:04
Copy link

vercel bot commented May 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2024 9:05pm
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) May 7, 2024 9:05pm
catalyst-au ⬜️ Ignored (Inspect) May 7, 2024 9:05pm
catalyst-test-store ⬜️ Ignored (Inspect) May 7, 2024 9:05pm
catalyst-uk ⬜️ Ignored (Inspect) May 7, 2024 9:05pm

Copy link

changeset-bot bot commented May 7, 2024

🦋 Changeset detected

Latest commit: ca4d17a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/catalyst-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented May 7, 2024

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-4y6lpc17j-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟢 Performance 100
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 90

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 100
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 92

@jorgemoya jorgemoya added this pull request to the merge queue May 7, 2024
Merged via the queue into main with commit 78a5f08 May 7, 2024
14 of 15 checks passed
@jorgemoya jorgemoya deleted the fix-nav-mobile branch May 7, 2024 21:23
@github-actions github-actions bot mentioned this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants