don't show featured products section if none exist (on not-found template) #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If featured products do not exist, not-found template still shows the <section> and the h3 headline. this commit fixes that with a length check / fallback of return null.
🦋 Changeset detectedLatest commit: 68684a5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@electricenjindevops is attempting to deploy a commit to the BigCommerce Platform Team on Vercel. A member of the Team first needs to authorize it. |
|
electricenjindevops
changed the title
|
Thanks for your contribution @electricenjindevops, I'll ask the team to review it. |
chanceaclark
approved these changes
May 6, 2024
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
jorgemoya
approved these changes
May 6, 2024
jorgemoya
approved these changes
May 6, 2024
|
Lint task is not going to work as it's being ran on a fork. We don't share our secrets with forked branches. Confirmed it worked locally though. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why?
The not found template doesn't account for stores that do not have any featured products, which is a dev error.
If featured products do not exist, not-found template still shows the section and the h3 headline. this commit fixes that with a length check / fallback of return null.
The git file changes may show a big block replacement, but the only changes are the if statement above the section open and else condition below the section close.
Testing
I tested by running two different Catalyst stores in dev & build, one on a store with no featured products, and one with featured products. I also had tested using a single store with featured products toggled on/off too.