feat(functional): Add new visual regression tests #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7411b28 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
avattipalli
force-pushed
the
visual_reg_mig
branch
from
ea5b283
to
b08c191
Compare
avattipalli
force-pushed
the
visual_reg_mig
branch
from
b08c191
to
2e065e5
Compare
fix: update workflows yml
avattipalli
force-pushed
the
visual_reg_mig
branch
from
2e065e5
to
782588d
Compare
chanceaclark
force-pushed
the
visual_reg_mig
branch
from
e4cab5b
to
66f384f
Compare
jorgemoya
approved these changes
May 3, 2024
avattipalli
force-pushed
the
visual_reg_mig
branch
from
d849de8
to
1a904e6
Compare
avattipalli
force-pushed
the
visual_reg_mig
branch
from
1a904e6
to
17d858a
Compare
⚡️🏠 Lighthouse reportLighthouse ran against https://catalyst-latest-2r9jzwsob-bigcommerce-platform.vercel.app 🖥️ DesktopWe ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:
📱 MobileWe ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:
|
deini
approved these changes
May 6, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why?
As we deprecated storybook usage, new visual regression tests had to be added in place of old ones relying on storybook. These tests rely on the catalyst store we regularly use for testing purposes.
Testing
Tested locally. Once the workflows are setup, new tests should run as part of the change.