Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(functional): Move functional tests to apps/core #816

Merged
merged 3 commits into from
Apr 25, 2024
Merged

Conversation

avattipalli
Copy link
Contributor

What/Why?

As part of making functional tests optionally available to our users, we are moving our tests to apps/core so that they are now available through CLI setup.

Testing

Tests should run as part of this PR. Verified it all locally.

@avattipalli avattipalli self-assigned this Apr 25, 2024
Copy link

changeset-bot bot commented Apr 25, 2024

🦋 Changeset detected

Latest commit: 99f2902

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/catalyst-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview Apr 25, 2024 5:34pm
catalyst-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2024 5:34pm
catalyst-test-store ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2024 5:34pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) Visit Preview Apr 25, 2024 5:34pm
catalyst-au ⬜️ Ignored (Inspect) Visit Preview Apr 25, 2024 5:34pm
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Apr 25, 2024 5:34pm

@avattipalli
Copy link
Contributor Author

Successful test runs on CI:

Playwright UI Tests
Playwright Visual Regression Tests

Copy link
Contributor

@chanceaclark chanceaclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments, otherwise looks good. I'll pull this down later to test with the CLI before I give a ✅

apps/core/package.json Outdated Show resolved Hide resolved
apps/core/tests/playwright.config.js Outdated Show resolved Hide resolved
@@ -0,0 +1,2 @@
# Environment variables for tests
PLAYWRIGHT_TEST_BASE_URL='https://catalyst-demo.site'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that I think about it, let's add remove this for now as we probably need to add some documentation around it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I have it documented in docs/monorepo.md but this might also be another placeholder to add it as it's an environment variable.

apps/core/playwright.config.js Outdated Show resolved Hide resolved
Copy link
Contributor

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-7pk50j0py-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟢 Performance 100
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 90

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 95
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 92

@avattipalli avattipalli added this pull request to the merge queue Apr 25, 2024
Merged via the queue into main with commit 7115843 Apr 25, 2024
18 checks passed
@avattipalli avattipalli deleted the migrate_tests branch April 25, 2024 17:39
@github-actions github-actions bot mentioned this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants