Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): split contact us and normal websites #810

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

deini
Copy link
Member

@deini deini commented Apr 23, 2024

What/Why?

  • Splits contact us and normal websites
  • Fragment composition where possible
  • Moves ContactUs component closer to usage

@deini deini requested a review from a team as a code owner April 23, 2024 20:02
Copy link

changeset-bot bot commented Apr 23, 2024

🦋 Changeset detected

Latest commit: b789ae1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/catalyst-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview Apr 23, 2024 8:02pm
catalyst-storybook ✅ Ready (Inspect) Visit Preview Apr 23, 2024 8:02pm
catalyst-test-store ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2024 8:02pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) Apr 23, 2024 8:02pm
catalyst-au ⬜️ Ignored (Inspect) Apr 23, 2024 8:02pm
catalyst-uk ⬜️ Ignored (Inspect) Apr 23, 2024 8:02pm

Copy link
Contributor

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-o2paiygmw-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟢 Performance 100
🟢 Accessibility 100
🟢 Best practices 100
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 98
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 92

@deini deini added this pull request to the merge queue Apr 24, 2024
Merged via the queue into main with commit 168cdda Apr 24, 2024
18 checks passed
@deini deini deleted the deini/webpage-composition branch April 24, 2024 15:29
@github-actions github-actions bot mentioned this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants