feat(core): add delete address functionality for account #787

bc-alexsaiannyi · 2024-04-18T14:05:27Z

What/Why?

This PR brings delete address functionality for Account.

Testing

locally

vercel · 2024-04-18T14:05:29Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
catalyst-au	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	May 16, 2024 10:04am
catalyst-core	❌ Failed (Inspect)			May 16, 2024 10:04am
catalyst-latest	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 16, 2024 10:04am
catalyst-storybook	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 16, 2024 10:04am
catalyst-test-store	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	May 16, 2024 10:04am

2 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
catalyst-1millionproducts-store	⬜️ Ignored (Inspect)	Visit Preview		May 16, 2024 10:04am
catalyst-uk	⬜️ Ignored (Inspect)	Visit Preview		May 16, 2024 10:04am

changeset-bot · 2024-04-18T14:05:32Z

🦋 Changeset detected

Latest commit: b20168c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@bigcommerce/catalyst-core	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

bc-alexsaiannyi · 2024-04-18T14:12:13Z

apps/core/app/[locale]/(default)/(faceted)/_components/pagination.tsx

+
+  if (startCursor) {
+    beforeSearchParams.set('before', String(startCursor));
+  }


FYI, I've experienced issues with navigation on deleting last item on page (like Customer's address). After the action I've received url like https://your-store/addresses?before=null which prevents smooth navigation afterwards. So I've put this condition and if there is no cursor we just basically return start position for pagination.

avattipalli

Can you please attach a PoL to this PR?

avattipalli · 2024-04-23T14:10:29Z

apps/core/messages/en.json

-      "deleteButton": "Delete"
+      "deleteButton": "Delete",
+      "confirmDeleteAddress": "Delete address",
+      "deleteModalTitle": "Are you sure you want to delete Address"


🍹 We can probably change this to Are you sure you want to delete address? or Are you sure? if we show the Delete Address somewhere within the dialog

Thanks, Anudeep. It's updated.

avattipalli · 2024-04-23T14:11:02Z

apps/core/app/[locale]/(default)/account/[tab]/_actions/delete-address.ts

+    revalidatePath('/account/addresses', 'page');
+
+    if (response.customer.deleteCustomerAddress.errors.length === 0) {
+      return { status: 'success', message: 'The address has been deleted' };


🍹 This address has been deleted

github-actions · 2024-05-16T10:06:17Z

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-n8umgdnq3-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category	Score
🟢 Performance	100
🟢 Accessibility	100
🟢 Best practices	100
🟢 SEO	90

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category	Score
🟢 Performance	99
🟢 Accessibility	100
🟢 Best practices	100
🟢 SEO	92

bc-alexsaiannyi requested a review from a team as a code owner April 18, 2024 14:05

vercel bot deployed to Preview – catalyst-latest April 18, 2024 14:05 View deployment

bc-alexsaiannyi commented Apr 18, 2024

View reviewed changes

bc-alexsaiannyi force-pushed the delete-address branch from 417f437 to cd51301 Compare April 23, 2024 13:53

vercel bot deployed to Preview – catalyst-storybook April 23, 2024 13:54 View deployment

vercel bot deployed to Preview – catalyst-latest April 23, 2024 13:55 View deployment

vercel bot deployed to Preview – catalyst-test-store April 23, 2024 13:56 View deployment

avattipalli reviewed Apr 23, 2024

View reviewed changes

vercel bot deployed to Preview – catalyst-storybook April 23, 2024 15:26 View deployment

vercel bot had a problem deploying to Preview – catalyst-test-store April 23, 2024 15:26 Failure

vercel bot had a problem deploying to Preview – catalyst-latest April 23, 2024 15:26 Failure

bc-alexsaiannyi force-pushed the delete-address branch from ef17a1e to 91b8f10 Compare April 23, 2024 15:28

bc-alexsaiannyi changed the title ~~feat(core): add delete address functionality for account~~ feat(core): add delete/add address functionality for account Apr 23, 2024

vercel bot deployed to Preview – catalyst-storybook April 23, 2024 15:29 View deployment

vercel bot had a problem deploying to Preview – catalyst-test-store April 23, 2024 15:30 Failure

vercel bot had a problem deploying to Preview – catalyst-latest April 23, 2024 15:30 Failure

bc-alexsaiannyi force-pushed the delete-address branch from 91b8f10 to b8570e8 Compare April 23, 2024 15:31

vercel bot had a problem deploying to Preview – catalyst-latest April 23, 2024 15:32 Failure

vercel bot had a problem deploying to Preview – catalyst-test-store April 23, 2024 15:32 Failure

vercel bot deployed to Preview – catalyst-storybook April 23, 2024 15:32 View deployment

bc-alexsaiannyi force-pushed the delete-address branch from b8570e8 to db6fa78 Compare April 23, 2024 16:05

vercel bot deployed to Preview – catalyst-storybook April 23, 2024 16:05 View deployment

vercel bot deployed to Preview – catalyst-latest April 23, 2024 16:07 View deployment

vercel bot deployed to Preview – catalyst-test-store April 23, 2024 16:07 View deployment

bc-alexsaiannyi force-pushed the delete-address branch from db6fa78 to f35b5d2 Compare April 23, 2024 16:08

vercel bot deployed to Preview – catalyst-storybook April 23, 2024 16:09 View deployment

vercel bot deployed to Preview – catalyst-test-store April 23, 2024 16:10 View deployment

vercel bot deployed to Preview – catalyst-latest April 23, 2024 16:10 View deployment

vercel bot deployed to Preview – catalyst-latest April 30, 2024 16:12 View deployment

chanceaclark approved these changes Apr 30, 2024

View reviewed changes

yurytut1993 approved these changes May 2, 2024

View reviewed changes

bc-alexsaiannyi force-pushed the delete-address branch from 3ff572e to f89bc86 Compare May 3, 2024 07:51

vercel bot had a problem deploying to Preview – catalyst-latest May 3, 2024 07:52 Failure

vercel bot had a problem deploying to Preview – catalyst-test-store May 3, 2024 07:52 Failure

bc-alexsaiannyi force-pushed the delete-address branch from f89bc86 to 1eecf0d Compare May 3, 2024 07:58

vercel bot deployed to Preview – catalyst-test-store May 3, 2024 08:00 View deployment

vercel bot deployed to Preview – catalyst-latest May 3, 2024 08:00 View deployment

jorgemoya approved these changes May 3, 2024

View reviewed changes

bc-alexsaiannyi force-pushed the delete-address branch from 1eecf0d to 13cde88 Compare May 8, 2024 10:37

vercel bot had a problem deploying to Preview – catalyst-core May 8, 2024 10:39 Failure

vercel bot deployed to Preview – catalyst-latest May 8, 2024 10:40 View deployment

bc-alexsaiannyi force-pushed the delete-address branch from 13cde88 to 635d862 Compare May 8, 2024 13:50

vercel bot deployed to Preview – catalyst-latest May 8, 2024 13:52 View deployment

bc-alexsaiannyi force-pushed the delete-address branch from 635d862 to c162f89 Compare May 9, 2024 09:28

vercel bot deployed to Preview – catalyst-latest May 9, 2024 09:30 View deployment

bc-alexsaiannyi force-pushed the delete-address branch from c162f89 to 97aa379 Compare May 9, 2024 09:32

vercel bot deployed to Preview – catalyst-latest May 9, 2024 09:34 View deployment

bc-alexsaiannyi force-pushed the delete-address branch from 97aa379 to bd343d0 Compare May 14, 2024 10:12

vercel bot deployed to Preview – catalyst-latest May 14, 2024 10:14 View deployment

feat(core): add delete address functionality for account

b20168c

bc-alexsaiannyi force-pushed the delete-address branch from bd343d0 to b20168c Compare May 16, 2024 10:02

vercel bot deployed to Preview – catalyst-latest May 16, 2024 10:04 View deployment

bc-alexsaiannyi added this pull request to the merge queue May 16, 2024

Merged via the queue into main with commit 6198648 May 16, 2024
11 checks passed

bc-alexsaiannyi deleted the delete-address branch May 16, 2024 10:14

github-actions bot mentioned this pull request May 16, 2024

Version Packages #879

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(core): add delete address functionality for account #787

feat(core): add delete address functionality for account #787

bc-alexsaiannyi commented Apr 18, 2024 •

edited

Loading

vercel bot commented Apr 18, 2024 •

edited

Loading

changeset-bot bot commented Apr 18, 2024 •

edited

Loading

bc-alexsaiannyi Apr 18, 2024

avattipalli left a comment

avattipalli Apr 23, 2024

bc-alexsaiannyi Apr 23, 2024

avattipalli Apr 23, 2024

github-actions bot commented May 16, 2024

feat(core): add delete address functionality for account #787

feat(core): add delete address functionality for account #787

Conversation

bc-alexsaiannyi commented Apr 18, 2024 • edited Loading

What/Why?

Testing

vercel bot commented Apr 18, 2024 • edited Loading

changeset-bot bot commented Apr 18, 2024 • edited Loading

🦋 Changeset detected

bc-alexsaiannyi Apr 18, 2024

Choose a reason for hiding this comment

avattipalli left a comment

Choose a reason for hiding this comment

avattipalli Apr 23, 2024

Choose a reason for hiding this comment

bc-alexsaiannyi Apr 23, 2024

Choose a reason for hiding this comment

avattipalli Apr 23, 2024

Choose a reason for hiding this comment

github-actions bot commented May 16, 2024

⚡️🏠 Lighthouse report

🖥️ Desktop

📱 Mobile

bc-alexsaiannyi commented Apr 18, 2024 •

edited

Loading

vercel bot commented Apr 18, 2024 •

edited

Loading

changeset-bot bot commented Apr 18, 2024 •

edited

Loading