-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): add loading state on item quantity change #783
Conversation
🦋 Changeset detectedLatest commit: e58f9ac The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
a1da41c
to
726674a
Compare
726674a
to
b7024b3
Compare
⚡️🏠 Lighthouse reportLighthouse ran against https://catalyst-latest-kik4dpdro-bigcommerce-platform.vercel.app 🖥️ DesktopWe ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:
📱 MobileWe ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:
|
<SubmitButton | ||
aria-label={t('submitReduceText')} | ||
onClick={() => setProductQuantity(productQuantity - 1)} | ||
> | ||
<Minus aria-hidden="true" /> | ||
</SubmitButton> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍹 Use aria-*
attributes as a last resort.
<SubmitButton | |
aria-label={t('submitReduceText')} | |
onClick={() => setProductQuantity(productQuantity - 1)} | |
> | |
<Minus aria-hidden="true" /> | |
</SubmitButton> | |
<SubmitButton onClick={() => setProductQuantity(productQuantity - 1)}> | |
<Minus> | |
<title>{t('submitReduceText')}</title> | |
</Minus> | |
</SubmitButton> |
What/Why?
Kapture.2024-04-17.at.14.10.43.mp4
Testing
Tests pass.