Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): use LRU cache for DevKvAdapter #779

Merged
merged 1 commit into from
Apr 17, 2024
Merged

feat(core): use LRU cache for DevKvAdapter #779

merged 1 commit into from
Apr 17, 2024

Conversation

deini
Copy link
Member

@deini deini commented Apr 17, 2024

What/Why?

Use an LRU cache for our dev kv adapter. This should work closer to how KV works in prod.

We will be dogfooding this for a bit, and potentially promote it to a non-dev adapter as it may benefit self-hosters.

Copy link

changeset-bot bot commented Apr 17, 2024

🦋 Changeset detected

Latest commit: 6ecbe78

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/catalyst-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview Apr 17, 2024 4:20pm
catalyst-test-store ✅ Ready (Inspect) Visit Preview Apr 17, 2024 4:20pm
4 Ignored Deployments
Name Status Preview Updated (UTC)
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) Apr 17, 2024 4:20pm
catalyst-au ⬜️ Ignored (Inspect) Apr 17, 2024 4:20pm
catalyst-storybook ⬜️ Ignored (Inspect) Apr 17, 2024 4:20pm
catalyst-uk ⬜️ Ignored (Inspect) Apr 17, 2024 4:20pm

@deini deini marked this pull request as ready for review April 17, 2024 16:23
@deini deini requested a review from a team as a code owner April 17, 2024 16:23
@deini deini added this pull request to the merge queue Apr 17, 2024
Merged via the queue into main with commit fe34b3e Apr 17, 2024
15 checks passed
@deini deini deleted the deini/lru branch April 17, 2024 16:41
@github-actions github-actions bot mentioned this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants