feat(core): Add tests for shipping estimates #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 57d3aa6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
avattipalli
force-pushed
the
shipping_estimate_tests
branch
from
85ca11b
to
629d17b
Compare
avattipalli
force-pushed
the
shipping_estimate_tests
branch
from
629d17b
to
c07f921
Compare
avattipalli
force-pushed
the
shipping_estimate_tests
branch
from
c07f921
to
844c30f
Compare
avattipalli
commented
Apr 15, 2024
| @@ -128,13 +128,17 @@ | |||
| }, | |||
| "ShippingInfo": { | |||
| "country": "Country", | |||
| "countryPlaceholder": "Select county", | |||
There was a problem hiding this comment.
Corrected a typo and added a few aria-label attributes.
avattipalli
changed the title
apps/core/app/[locale]/(default)/cart/_components/shipping-info.tsx
Outdated
Show resolved
Hide resolved
apps/core/app/[locale]/(default)/cart/_components/shipping-info.tsx
Outdated
Show resolved
Hide resolved
avattipalli
force-pushed
the
shipping_estimate_tests
branch
from
78d951f
to
57d3aa6
Compare
chanceaclark
approved these changes
Apr 16, 2024
⚡️🏠 Lighthouse reportLighthouse ran against https://catalyst-latest-b5kxam9ak-bigcommerce-platform.vercel.app 🖥️ DesktopWe ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:
📱 MobileWe ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why?
Add UI tests for calculating shipping estimates on cart items.
Testing
Newly added tests should run on this PR.