Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add get customer query #768

Merged
merged 1 commit into from
Apr 16, 2024
Merged

feat(core): add get customer query #768

merged 1 commit into from
Apr 16, 2024

Conversation

yurytut1993
Copy link
Contributor

What/Why?

This pr adds query to get Customer's account data

Testing

Locally

@yurytut1993 yurytut1993 requested a review from a team as a code owner April 15, 2024 20:16
Copy link

changeset-bot bot commented Apr 15, 2024

🦋 Changeset detected

Latest commit: 3aa09b1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/catalyst-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 16, 2024 1:48pm
catalyst-test-store ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 16, 2024 1:48pm
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) Visit Preview Apr 16, 2024 1:48pm
catalyst-au ⬜️ Ignored (Inspect) Visit Preview Apr 16, 2024 1:48pm
catalyst-storybook ⬜️ Ignored (Inspect) Visit Preview Apr 16, 2024 1:48pm
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Apr 16, 2024 1:48pm

Copy link
Contributor

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-u9ge5jfzt-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟢 Performance 100
🟢 Accessibility 100
🟠 Best practices 78
🟢 SEO 90

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 97
🟢 Accessibility 100
🟠 Best practices 78
🟢 SEO 92

export const getCustomer = cache(async (customerId: string) => {
const response = await client.fetch({
document: GET_CUSTOMER_QUERY,
fetchOptions: { next: { revalidate } },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't we need to use here cache: 'no-store' option for Customer?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch 👍 thanks

@yurytut1993 yurytut1993 added this pull request to the merge queue Apr 16, 2024
Merged via the queue into main with commit 39feb4a Apr 16, 2024
15 checks passed
@yurytut1993 yurytut1993 deleted the get-customer-query branch April 16, 2024 13:49
@github-actions github-actions bot mentioned this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants