Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move packages/components into core #767

Merged
merged 4 commits into from
Apr 30, 2024
Merged

Conversation

jorgemoya
Copy link
Contributor

@jorgemoya jorgemoya commented Apr 15, 2024

What/Why?

Move packages/components into core components/ui.

  • Merged package.json and tailwind.config into core.
  • Updated changeset configuration.

Testing

Locally.

Copy link

changeset-bot bot commented Apr 15, 2024

🦋 Changeset detected

Latest commit: 2ae2ef0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/catalyst-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2024 9:48pm
catalyst-storybook ❌ Failed (Inspect) Apr 30, 2024 9:48pm
catalyst-test-store ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2024 9:48pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) Visit Preview Apr 30, 2024 9:48pm
catalyst-au ⬜️ Ignored (Inspect) Visit Preview Apr 30, 2024 9:48pm
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Apr 30, 2024 9:48pm

@jorgemoya jorgemoya requested a review from a team as a code owner April 30, 2024 19:29
@jorgemoya
Copy link
Contributor Author

Disabled Visual Regression tests to unblock this PR.

@jorgemoya
Copy link
Contributor Author

Splitting PR into commits/multiple PRs.

pnpm-lock.yaml Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you haven't already, I would make sure to rerun pnpm install after you removed the old package.json.

Copy link
Contributor

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-319x54960-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟢 Performance 100
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 90

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 99
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 92

@jorgemoya jorgemoya added this pull request to the merge queue Apr 30, 2024
Merged via the queue into main with commit c740cdd Apr 30, 2024
12 checks passed
@jorgemoya jorgemoya deleted the move-components-core branch April 30, 2024 21:53
@github-actions github-actions bot mentioned this pull request Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants