feat(core): add addresses tab content #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8ea4c99 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
|
|
||
| export const AddressesContent = async ({ addresses, pageInfo, title }: Props) => { | ||
| // eslint-disable-next-line @typescript-eslint/consistent-type-assertions | ||
| const locale = (await getLocale()) as LocaleType; |
There was a problem hiding this comment.
Suggested change
| const locale = (await getLocale()) as LocaleType; | |
| const locale = await getLocale(); |
Probably you don't need type assertion here
There was a problem hiding this comment.
Yeah, I've simplified type here to string.
bc-alexsaiannyi
force-pushed
the
addresses-tab
branch
2 times, most recently
from
0a002c7
to
83ecb68
Compare
jorgemoya
approved these changes
Apr 15, 2024
bc-alexsaiannyi
force-pushed
the
addresses-tab
branch
from
83ecb68
to
892080a
Compare
⚡️🏠 Lighthouse reportLighthouse ran against https://catalyst-latest-ja2b5m1u2-bigcommerce-platform.vercel.app 🖥️ DesktopWe ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:
📱 MobileWe ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:
|
yurytut1993
approved these changes
Apr 16, 2024
bc-azvierieva
approved these changes
Apr 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why?
This PR adds a list of customer's addresses. Edit, delete or add new address will be added separately.
Testing
locally