Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): hide discounts from checkout if null #732

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Conversation

jorgemoya
Copy link
Contributor

What/Why?

Only show discount if there are any.

Testing

Locally.

@jorgemoya jorgemoya requested a review from a team as a code owner April 4, 2024 15:46
Copy link

changeset-bot bot commented Apr 4, 2024

🦋 Changeset detected

Latest commit: 50647de

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/catalyst-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2024 3:52pm
catalyst-testbed ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2024 3:52pm
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) Visit Preview Apr 4, 2024 3:52pm
catalyst-au ⬜️ Ignored (Inspect) Visit Preview Apr 4, 2024 3:52pm
catalyst-storybook ⬜️ Ignored (Inspect) Visit Preview Apr 4, 2024 3:52pm
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Apr 4, 2024 3:52pm

Copy link
Contributor

github-actions bot commented Apr 4, 2024

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-nrysq114z-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟢 Performance 100
🟢 Accessibility 100
🟠 Best practices 78
🟢 SEO 90

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 99
🟢 Accessibility 100
🟠 Best practices 78
🟢 SEO 92

@jorgemoya jorgemoya added this pull request to the merge queue Apr 4, 2024
Merged via the queue into main with commit ea5a690 Apr 4, 2024
14 of 15 checks passed
@jorgemoya jorgemoya deleted the hide-discounts branch April 4, 2024 16:01
@github-actions github-actions bot mentioned this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants