feat(core): add tax total in checkout summary #731
Conversation
🦋 Changeset detectedLatest commit: cecbc66 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
| @@ -47,6 +47,11 @@ export const CheckoutSummary = async ({ cartId, locale }: { cartId: string; loca | |||
| <span>-{currencyFormatter.format(checkout.cart?.discountedAmount.value || 0)}</span> | |||
| </div> | |||
|
|
|||
| <div className="flex justify-between border-t border-t-gray-200 py-4"> | |||
| <span className="font-semibold">{t('tax')}</span> | |||
| <span>{currencyFormatter.format(checkout.taxTotal?.value || 0)}</span> | |||
There was a problem hiding this comment.
🍹 Curious why taxTotal can be missing here. The fallback of 0 seems reasonable but if it represents a concept of tax not existing at all I wonder if it's more appropriate to not show the tax field at all. (not a blocker at all for merging though imho)
There was a problem hiding this comment.
That is reasonable, I can update and represent this.
⚡️🏠 Lighthouse reportLighthouse ran against https://catalyst-latest-8eypupyf0-bigcommerce-platform.vercel.app 🖥️ DesktopWe ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:
📱 MobileWe ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:
|
What/Why?
Add total tax from checkout.
Testing
Locally.