feat(core): create register customer page #730

yurytut1993 · 2024-04-04T11:47:12Z

What/Why?

This pr adds Register Customer Page with Built In Fields

Testing

Locally

changeset-bot · 2024-04-04T11:47:16Z

🦋 Changeset detected

Latest commit: b0dac9f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@bigcommerce/catalyst-core	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2024-04-04T11:47:24Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
catalyst-core	❌ Failed (Inspect)			May 13, 2024 11:51am
catalyst-latest	✅ Ready (Inspect)	Visit Preview		May 13, 2024 11:51am
catalyst-storybook	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 13, 2024 11:51am
catalyst-testbed	❌ Failed (Inspect)			May 13, 2024 11:51am

4 Ignored Deployments

Name	Status	Preview	Updated (UTC)
catalyst-1millionproducts-store	⬜️ Ignored (Inspect)	Visit Preview	May 13, 2024 11:51am
catalyst-au	⬜️ Ignored (Inspect)	Visit Preview	May 13, 2024 11:51am
catalyst-test-store	⬜️ Ignored (Inspect)	Visit Preview	May 13, 2024 11:51am
catalyst-uk	⬜️ Ignored (Inspect)	Visit Preview	May 13, 2024 11:51am

bc-alexsaiannyi · 2024-04-10T15:44:29Z

packages/components/src/components/form/form.tsx

@@ -15,7 +15,8 @@ type ValidationPattern =
  | 'tooShort'
  | 'typeMismatch'
  | 'valid'
-  | 'valueMissing';
+  | 'valueMissing'
+  | ValidationFunction;


I think there can be an error in ControlValidationPatterns so basically you can update and use ControlValidationPatterns after:
type ControlValidationPatterns = ValidationPattern | ValidationFunction;
What do you think?

Yes, changed after your updates

jorgemoya

IMO /register-customer-form should be nested under a _components folder in the register-customer path, since it's not reused.

jorgemoya · 2024-04-11T18:32:52Z

apps/core/app/[locale]/(default)/account/register-customer/page.tsx

+import { getCountries } from '~/client/management/get-countries';
+import { getAddressFormFields } from '~/client/queries/get-address-form-fields';
+import { getCustomerFormFields } from '~/client/queries/get-customer-form-fields';
+import { getReCaptchaSettings } from '~/client/queries/get-recaptcha-settings';
+import { getStoreCountry } from '~/client/queries/get-store-country';


Can we do this with a single query?

Interesting idea, but getAddressFormFields, getAddressFormFields and getReCaptchaSettings need to be used in separate cases 🤔

You can try something like what @deini is doing with fragment colocation. What do you think?

@jorgemoya thats great idea, thanks. Refactored according to the new approach 👍

apps/core/components/register-customer-form/_actions/login.ts

bc-alexsaiannyi · 2024-04-18T10:19:57Z

IMO /register-customer-form should be nested under a _components folder in the register-customer path, since it's not reused.

Hmm, It's interested point. I guess that in this case it makes sense to move contactUs form to relevant page _components and delete core/components/forms altogether. What do you think guys?🤔

yurytut1993 · 2024-04-18T10:36:26Z

IMO /register-customer-form should be nested under a _components folder in the register-customer path, since it's not reused.

Hmm, It's interested point. I guess that in this case it makes sense to move contactUs form to relevant page _components and delete core/components/forms altogether. What do you think guys?🤔

It will be consistent. And blog-post-card also should be replaced under Blog then

bc-alexsaiannyi · 2024-04-23T08:58:13Z

apps/core/components/register-customer-form/_actions/register-customer.ts

+    { address: {} },
+  );
+
+  console.log(parsedData, 'parsedData');


don't forget to remove console

bc-alexsaiannyi · 2024-04-23T08:59:27Z

apps/core/components/register-customer-form/index.tsx

+    setCountryStates(data);
+  };
+
+  const handlePicklistWihtTextValidation = (e: ChangeEvent<HTMLInputElement>) => {


here is a typo in method's name.

bc-azvierieva

Nice job!

github-actions · 2024-05-13T11:53:26Z

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-5d59de1i0-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category	Score
🟢 Performance	100
🟢 Accessibility	100
🟢 Best practices	100
🟢 SEO	90

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category	Score
🟢 Performance	96
🟢 Accessibility	100
🟢 Best practices	100
🟢 SEO	92

vercel bot had a problem deploying to Preview – catalyst-latest April 4, 2024 11:47 Failure

yurytut1993 force-pushed the register-customer-page branch from 13724b3 to 7a9bd6d Compare April 8, 2024 13:29

vercel bot had a problem deploying to Preview – catalyst-testbed April 8, 2024 13:30 Failure

vercel bot had a problem deploying to Preview – catalyst-latest April 8, 2024 13:31 Failure

bc-alexsaiannyi reviewed Apr 10, 2024

View reviewed changes

yurytut1993 force-pushed the register-customer-page branch from 7a9bd6d to 9684f20 Compare April 11, 2024 08:57

vercel bot had a problem deploying to Preview – catalyst-testbed April 11, 2024 08:58 Failure

vercel bot had a problem deploying to Preview – catalyst-latest April 11, 2024 09:00 Failure

yurytut1993 force-pushed the register-customer-page branch from 9684f20 to 9cf15f0 Compare April 11, 2024 10:21

vercel bot had a problem deploying to Preview – catalyst-testbed April 11, 2024 10:22 Failure

vercel bot had a problem deploying to Preview – catalyst-latest April 11, 2024 10:23 Failure

yurytut1993 force-pushed the register-customer-page branch from 9cf15f0 to eb39d48 Compare April 11, 2024 10:38

vercel bot had a problem deploying to Preview – catalyst-testbed April 11, 2024 10:39 Failure

vercel bot had a problem deploying to Preview – catalyst-latest April 11, 2024 10:40 Failure

yurytut1993 marked this pull request as ready for review April 11, 2024 10:42

yurytut1993 requested a review from a team as a code owner April 11, 2024 10:42

jorgemoya reviewed Apr 11, 2024

View reviewed changes

bc-alexsaiannyi reviewed Apr 23, 2024

View reviewed changes

yurytut1993 force-pushed the register-customer-page branch from eb39d48 to b876e08 Compare April 29, 2024 17:02

vercel bot deployed to Preview – catalyst-storybook April 29, 2024 17:03 View deployment

vercel bot deployed to Preview – catalyst-test-store April 29, 2024 17:05 View deployment

vercel bot deployed to Preview – catalyst-latest April 29, 2024 17:06 View deployment

yurytut1993 force-pushed the register-customer-page branch from b876e08 to 6e2602f Compare April 29, 2024 18:44

vercel bot deployed to Preview – catalyst-storybook April 29, 2024 18:45 View deployment

vercel bot deployed to Preview – catalyst-latest April 29, 2024 18:46 View deployment

vercel bot deployed to Preview – catalyst-test-store May 3, 2024 12:28 View deployment

jorgemoya approved these changes May 3, 2024

View reviewed changes

yurytut1993 force-pushed the register-customer-page branch from 116cb79 to 39237a6 Compare May 8, 2024 07:10

vercel bot had a problem deploying to Preview – catalyst-core May 8, 2024 07:12 Failure

vercel bot deployed to Preview – catalyst-latest May 8, 2024 07:13 View deployment

yurytut1993 force-pushed the register-customer-page branch from 39237a6 to 829542b Compare May 8, 2024 07:14

vercel bot had a problem deploying to Preview – catalyst-core May 8, 2024 07:16 Failure

vercel bot deployed to Preview – catalyst-latest May 8, 2024 07:16 View deployment

vercel bot deployed to Preview – catalyst-latest May 9, 2024 11:20 View deployment

yurytut1993 force-pushed the register-customer-page branch from 2356444 to 3f34f46 Compare May 9, 2024 11:26

vercel bot deployed to Preview – catalyst-latest May 9, 2024 11:28 View deployment

yurytut1993 force-pushed the register-customer-page branch from 3f34f46 to 7cfe738 Compare May 9, 2024 11:44

vercel bot deployed to Preview – catalyst-latest May 9, 2024 11:46 View deployment

yurytut1993 force-pushed the register-customer-page branch from 7cfe738 to 9e44131 Compare May 9, 2024 12:09

vercel bot deployed to Preview – catalyst-latest May 9, 2024 12:11 View deployment

yurytut1993 force-pushed the register-customer-page branch from 9e44131 to adfe121 Compare May 10, 2024 09:50

vercel bot deployed to Preview – catalyst-latest May 10, 2024 09:53 View deployment

bc-azvierieva approved these changes May 10, 2024

View reviewed changes

yurytut1993 force-pushed the register-customer-page branch from adfe121 to f722907 Compare May 13, 2024 10:38

vercel bot deployed to Preview – catalyst-latest May 13, 2024 10:40 View deployment

feat(core): create register customer page

b0dac9f

yurytut1993 force-pushed the register-customer-page branch from f722907 to b0dac9f Compare May 13, 2024 11:50

vercel bot deployed to Preview – catalyst-latest May 13, 2024 11:51 View deployment

yurytut1993 added this pull request to the merge queue May 13, 2024

Merged via the queue into main with commit 15e4b82 May 13, 2024
11 checks passed

yurytut1993 deleted the register-customer-page branch May 13, 2024 12:34

This was referenced May 13, 2024

Version Packages #879

Merged

Version Packages jasuppal-bc/catalyst#1

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(core): create register customer page #730

feat(core): create register customer page #730

yurytut1993 commented Apr 4, 2024 •

edited

Loading

changeset-bot bot commented Apr 4, 2024 •

edited

Loading

vercel bot commented Apr 4, 2024 •

edited

Loading

bc-alexsaiannyi Apr 10, 2024

yurytut1993 Apr 11, 2024

jorgemoya left a comment

jorgemoya Apr 11, 2024

yurytut1993 Apr 17, 2024

jorgemoya Apr 17, 2024

yurytut1993 Apr 30, 2024

bc-alexsaiannyi commented Apr 18, 2024

yurytut1993 commented Apr 18, 2024

bc-alexsaiannyi Apr 23, 2024

bc-alexsaiannyi Apr 23, 2024

bc-azvierieva left a comment

github-actions bot commented May 13, 2024

feat(core): create register customer page #730

feat(core): create register customer page #730

Conversation

yurytut1993 commented Apr 4, 2024 • edited Loading

What/Why?

Testing

changeset-bot bot commented Apr 4, 2024 • edited Loading

🦋 Changeset detected

vercel bot commented Apr 4, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jorgemoya left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bc-alexsaiannyi commented Apr 18, 2024

yurytut1993 commented Apr 18, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bc-azvierieva left a comment

Choose a reason for hiding this comment

github-actions bot commented May 13, 2024

⚡️🏠 Lighthouse report

🖥️ Desktop

📱 Mobile

yurytut1993 commented Apr 4, 2024 •

edited

Loading

changeset-bot bot commented Apr 4, 2024 •

edited

Loading

vercel bot commented Apr 4, 2024 •

edited

Loading