-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): add tabs for customer account #719
Conversation
🦋 Changeset detectedLatest commit: e0c25ec The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
|
||
export type TabType = | ||
| 'orders' | ||
| 'messages' | ||
| 'addresses' | ||
| 'wishlists' | ||
| 'recently-viewed' | ||
| 'settings'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can make this a single source of truth?
export type TabType = | |
| 'orders' | |
| 'messages' | |
| 'addresses' | |
| 'wishlists' | |
| 'recently-viewed' | |
| 'settings'; | |
export const tabList = ['orders', 'messages', 'addresses', 'wishlists', 'recently-viewed', 'settings'] as const | |
export type TabType = keyof tabList; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Chance. I've updated but with small changes. while trying to export tabList
I got an error ... is not a valid Next.js entry export value
and since we use tablist
as prop in <AccountTabs/>
so I moved both of them to layout and export only TabType
across page & component. What do you think?
I was playing with it on the demo site and it seems like there's a delay between when a tab is selected vs when the content renders. Wondering if we can do something about it so that it looks like an exact match, like using the path to select the tab. Kapture.2024-04-02.at.20.08.21.mp4 |
c0de628
to
f3804cb
Compare
f3804cb
to
0ecc506
Compare
0ecc506
to
906f4d3
Compare
906f4d3
to
accb92b
Compare
accb92b
to
efb999d
Compare
efb999d
to
d81c9d0
Compare
d81c9d0
to
b8576f6
Compare
b8576f6
to
b543637
Compare
b543637
to
d010bd5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job!
d010bd5
to
fa23a8b
Compare
fa23a8b
to
e0c25ec
Compare
⚡️🏠 Lighthouse reportLighthouse ran against https://catalyst-latest-hdlaxeeer-bigcommerce-platform.vercel.app 🖥️ DesktopWe ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:
📱 MobileWe ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:
|
What/Why?
This PR adds tabs for Customer's account page.
Testing
Locally