feat(core): fetch and show digital items in Cart #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c7cadde The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
jorgemoya
changed the title
chanceaclark
approved these changes
Mar 28, 2024
apps/core/app/[locale]/(default)/cart/_components/shipping-info.tsx
Outdated
Show resolved
Hide resolved
| @@ -44,19 +44,5 @@ export async function updateProductQuantity({ | |||
| throw new Error('Failed to change product quantity in Cart'); | |||
| } | |||
|
|
|||
| // reset shipping estimation on update product quantity | |||
| cookies().set({ | |||
chanceaclark
approved these changes
Mar 28, 2024
deini
approved these changes
Mar 28, 2024
| export const CartItem = async ({ product }: { product: Product }) => { | ||
| const t = await getTranslations('Cart'); | ||
|
|
||
| const extractCartlineItemsData = ({ |
There was a problem hiding this comment.
🍹 Not from this PR but maybe a quick win, thoughts on changing CartItemCounter to avoid this?
There was a problem hiding this comment.
Like pass in props instead of a single object?
jorgemoya
force-pushed
the
add-digital-items
branch
from
1e4d1dd
to
f854288
Compare
jorgemoya
force-pushed
the
add-digital-items
branch
from
929ee42
to
c7cadde
Compare
⚡️🏠 Lighthouse reportWe ran Lighthouse against the changes and produced this report. Here's the summary:
Lighthouse ran against https://catalyst-latest-g0ctvfdp6-bigcommerce-platform.vercel.app/ |
This was referenced Mar 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds of #711 to show correct pricing info.
What/Why?
Fetch and show digital items in Cart.
Testing
Locally