feat(core): add customer change password for logged-in customer #704

bc-alexsaiannyi · 2024-03-25T14:24:45Z

What/Why?

This PR adds functionality for changed password if Customer is logged in.

Account settings form is a placehodler. Will be updated in separate PR.

Testing

locally

changeset-bot · 2024-03-25T14:24:48Z

🦋 Changeset detected

Latest commit: 3c9ee32

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@bigcommerce/catalyst-core	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2024-03-25T14:24:53Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
catalyst-core	❌ Failed (Inspect)			May 8, 2024 1:42pm
catalyst-latest	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 8, 2024 1:42pm
catalyst-storybook	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 8, 2024 1:42pm
catalyst-testbed	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 8, 2024 1:42pm

4 Ignored Deployments

Name	Status	Preview	Updated (UTC)
catalyst-1millionproducts-store	⬜️ Ignored (Inspect)	Visit Preview	May 8, 2024 1:42pm
catalyst-au	⬜️ Ignored (Inspect)	Visit Preview	May 8, 2024 1:42pm
catalyst-test-store	⬜️ Ignored (Inspect)	Visit Preview	May 8, 2024 1:42pm
catalyst-uk	⬜️ Ignored (Inspect)	Visit Preview	May 8, 2024 1:42pm

matthewvolk

Testing locally seems to work! However, rather than including the account settings placeholder in this PR, can we just add the code required for changing passwords to work?

The reason behind this request is because if we cut another Catalyst release with the placeholder work included, people will be creating Catalyst storefronts locally with placeholder forms and that could lead to confusion, I'd imagine.

bc-alexsaiannyi · 2024-03-26T13:41:49Z

...

The reason behind this request is because if we cut another Catalyst release with the placeholder work included, people will be creating Catalyst storefronts locally with placeholder forms and that could lead to confusion, I'd imagine.

Hey, Matt. Yeah, it's a fair point so I've removed account-settings-form together with app router related to account's tabs ( account settings form is also one of these tabs). Now PR should be little bit cleaner in terms of functionality.

Confirmed functionality still works - but didn't have a chance to finish code review. Will finish ASAP!

yurytut1993 · 2024-03-27T08:11:59Z

apps/core/app/[locale]/(default)/login/_components/change-password-form.tsx

+    if (e.target.form) {
+      formData = new FormData(e.target.form);
+    }


can we have a case when we have no form and formData is null?

Yeah, it's a good question. e.target.form possibly can be null but your question brought me up to a small refactoring -I've simplified code and removed checking for FormData is null on a second step. Now it's done like:

if (e.target.form) { currentPasswordValue = new FormData(e.target.form).get('current-password'); }

Thanks!

yurytut1993

👍

deini · 2024-03-28T19:44:07Z

apps/core/app/[locale]/(default)/account/page.tsx


  if (!session) {
    redirect('/login');
  }

+  if (action === 'reset_password') {


Thoughts on having this as a different page? Should help simplify change-password-form.ts

Do you mean to create separate page alongside change-password-form that will be used exclusively for logged-in Customers?🤔

To chime in on this, there is usually two flows for how to change your password:

Update your password when logged in – has a session tied to it.

Forgot your password as a guest – the email sent to the user will contain a redirect link with code to generate a "session" in order to validate changing the password.

Since those are two separate use-cases, I think sharing a form shouldn't be an option here, especially from a security perspective.

Thanks, guys. it's updated

deini · 2024-03-28T19:52:31Z

apps/core/app/[locale]/(default)/login/_components/change-password-form.tsx

+    let newPasswordValue: FormDataEntryValue | null = null;
+    const confirmPasswordValue = e.target.value;

-    return setIsConfirmPasswordValid(confirmPassword === newPassword);
+    if (e.target.form) {
+      newPasswordValue = new FormData(e.target.form).get('new-password');
+    }
+
+    setIsConfirmPasswordValid(
+      confirmPasswordValue.length > 0 && newPasswordValue === confirmPasswordValue,
+    );
  };


Can we use the schema CustomerChangePasswordSchema here? We can modify it to check for equality and length requirements.

I've refactored this part but not sure if it's for good. it looks bulkier now. What do you say?

jorgemoya · 2024-04-30T21:50:15Z

.../[locale]/(default)/account/change-password/_actions/submit-customer-change-password-form.ts

+      };
+    }
+
+    return { status: 'error', message: 'Unknown error' };


Suggested change

return { status: 'error', message: 'Unknown error' };

return { status: 'error', message: 'Unknown error.' };

jorgemoya · 2024-04-30T21:50:53Z

.../[locale]/(default)/account/change-password/_actions/submit-customer-change-password-form.ts

+    });
+
+    if (response.errors.length === 0) {
+      return { status: 'success', message: '' };


Should we return response here?

I've added a message here but we basically don't use any data.

github-actions · 2024-05-08T13:44:36Z

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-gzpcucyzw-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category	Score
🟢 Performance	100
🟢 Accessibility	100
🟢 Best practices	100
🟢 SEO	90

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category	Score
🟠 Performance	89
🟢 Accessibility	100
🟢 Best practices	100
🟢 SEO	92

bc-alexsaiannyi requested a review from a team as a code owner March 25, 2024 14:24

vercel bot deployed to Preview – catalyst-latest March 25, 2024 14:25 View deployment

bc-alexsaiannyi force-pushed the customer-change-password branch from 49b2456 to 939ff64 Compare March 25, 2024 14:25

vercel bot deployed to Preview – catalyst-latest March 25, 2024 14:27 View deployment

matthewvolk previously requested changes Mar 25, 2024

View reviewed changes

bc-alexsaiannyi force-pushed the customer-change-password branch from 939ff64 to 62266a4 Compare March 26, 2024 13:37

vercel bot deployed to Preview – catalyst-latest March 26, 2024 13:42 View deployment

bc-alexsaiannyi force-pushed the customer-change-password branch from 62266a4 to a8c154d Compare March 26, 2024 20:36

vercel bot deployed to Preview – catalyst-latest March 26, 2024 20:40 View deployment

bc-alexsaiannyi force-pushed the customer-change-password branch from a8c154d to 631ef8e Compare March 26, 2024 20:43

vercel bot deployed to Preview – catalyst-latest March 26, 2024 20:47 View deployment

yurytut1993 reviewed Mar 27, 2024

View reviewed changes

bc-alexsaiannyi force-pushed the customer-change-password branch from 631ef8e to 7098eff Compare March 27, 2024 10:04

vercel bot deployed to Preview – catalyst-latest March 27, 2024 10:08 View deployment

yurytut1993 approved these changes Mar 27, 2024

View reviewed changes

deini reviewed Mar 28, 2024

View reviewed changes

bc-alexsaiannyi force-pushed the customer-change-password branch from 7098eff to b09b8b1 Compare April 3, 2024 16:27

vercel bot deployed to Preview – catalyst-testbed April 3, 2024 16:32 View deployment

vercel bot deployed to Preview – catalyst-latest April 3, 2024 16:32 View deployment

bc-alexsaiannyi force-pushed the customer-change-password branch from b09b8b1 to 7b08e8e Compare April 3, 2024 18:25

vercel bot deployed to Preview – catalyst-testbed April 3, 2024 18:28 View deployment

vercel bot deployed to Preview – catalyst-latest April 3, 2024 18:28 View deployment

bc-alexsaiannyi force-pushed the customer-change-password branch from 7b08e8e to 805541e Compare April 3, 2024 18:37

vercel bot deployed to Preview – catalyst-testbed April 3, 2024 18:40 View deployment

vercel bot deployed to Preview – catalyst-latest April 3, 2024 18:40 View deployment

bc-alexsaiannyi force-pushed the customer-change-password branch from 805541e to 9a84033 Compare April 9, 2024 09:52

vercel bot deployed to Preview – catalyst-test-store April 25, 2024 16:17 View deployment

bc-alexsaiannyi force-pushed the customer-change-password branch from 7d1bdde to 0b20ce4 Compare April 30, 2024 16:15

vercel bot deployed to Preview – catalyst-storybook April 30, 2024 16:16 View deployment

vercel bot deployed to Preview – catalyst-latest April 30, 2024 16:18 View deployment

vercel bot deployed to Preview – catalyst-test-store April 30, 2024 16:20 View deployment

jorgemoya approved these changes Apr 30, 2024

View reviewed changes

bc-alexsaiannyi force-pushed the customer-change-password branch 2 times, most recently from 95f9458 to ed3124b Compare May 3, 2024 08:48

vercel bot deployed to Preview – catalyst-latest May 3, 2024 08:52 View deployment

vercel bot deployed to Preview – catalyst-test-store May 3, 2024 08:52 View deployment

jorgemoya approved these changes May 3, 2024

View reviewed changes

bc-alexsaiannyi force-pushed the customer-change-password branch from ed3124b to b28a50d Compare May 7, 2024 08:37

vercel bot deployed to Preview – catalyst-latest May 7, 2024 08:39 View deployment

vercel bot deployed to Preview – catalyst-test-store May 7, 2024 08:40 View deployment

bc-alexsaiannyi force-pushed the customer-change-password branch from b28a50d to f90e97d Compare May 7, 2024 08:49

vercel bot deployed to Preview – catalyst-latest May 7, 2024 08:51 View deployment

vercel bot deployed to Preview – catalyst-test-store May 7, 2024 08:52 View deployment

bc-alexsaiannyi force-pushed the customer-change-password branch from f90e97d to b09b19c Compare May 8, 2024 10:01

vercel bot had a problem deploying to Preview – catalyst-core May 8, 2024 10:02 Failure

vercel bot deployed to Preview – catalyst-latest May 8, 2024 10:04 View deployment

feat(core): add change password for logged-in customer

3c9ee32

bc-alexsaiannyi force-pushed the customer-change-password branch from b09b19c to 3c9ee32 Compare May 8, 2024 13:41

vercel bot deployed to Preview – catalyst-latest May 8, 2024 13:42 View deployment

bc-alexsaiannyi added this pull request to the merge queue May 8, 2024

Merged via the queue into main with commit 6e93873 May 8, 2024
11 checks passed

bc-alexsaiannyi deleted the customer-change-password branch May 8, 2024 13:46

This was referenced May 8, 2024

Version Packages #879

Merged

Version Packages jasuppal-bc/catalyst#1

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(core): add customer change password for logged-in customer #704

feat(core): add customer change password for logged-in customer #704

bc-alexsaiannyi commented Mar 25, 2024 •

edited

Loading

changeset-bot bot commented Mar 25, 2024 •

edited

Loading

vercel bot commented Mar 25, 2024 •

edited

Loading

matthewvolk left a comment

bc-alexsaiannyi commented Mar 26, 2024

yurytut1993 Mar 27, 2024

bc-alexsaiannyi Mar 27, 2024 •

edited

Loading

yurytut1993 left a comment

deini Mar 28, 2024

bc-alexsaiannyi Mar 29, 2024

chanceaclark Mar 29, 2024

bc-alexsaiannyi Apr 3, 2024

deini Mar 28, 2024

bc-alexsaiannyi Apr 3, 2024 •

edited

Loading

jorgemoya Apr 30, 2024

jorgemoya Apr 30, 2024

bc-alexsaiannyi May 3, 2024

github-actions bot commented May 8, 2024

	return { status: 'error', message: 'Unknown error' };
	return { status: 'error', message: 'Unknown error.' };

feat(core): add customer change password for logged-in customer #704

feat(core): add customer change password for logged-in customer #704

Conversation

bc-alexsaiannyi commented Mar 25, 2024 • edited Loading

What/Why?

Testing

changeset-bot bot commented Mar 25, 2024 • edited Loading

🦋 Changeset detected

vercel bot commented Mar 25, 2024 • edited Loading

matthewvolk left a comment

Choose a reason for hiding this comment

bc-alexsaiannyi commented Mar 26, 2024

Choose a reason for hiding this comment

bc-alexsaiannyi Mar 27, 2024 • edited Loading

Choose a reason for hiding this comment

yurytut1993 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bc-alexsaiannyi Apr 3, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented May 8, 2024

⚡️🏠 Lighthouse report

🖥️ Desktop

📱 Mobile

bc-alexsaiannyi commented Mar 25, 2024 •

edited

Loading

changeset-bot bot commented Mar 25, 2024 •

edited

Loading

vercel bot commented Mar 25, 2024 •

edited

Loading

bc-alexsaiannyi Mar 27, 2024 •

edited

Loading

bc-alexsaiannyi Apr 3, 2024 •

edited

Loading