Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add change password mutation for logged in customer #683

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

bc-alexsaiannyi
Copy link
Contributor

What/Why?

This PR adds mutation for logged in Customer to update password on Account

Testing

locally.

@bc-alexsaiannyi bc-alexsaiannyi requested a review from a team as a code owner March 20, 2024 14:20
Copy link

changeset-bot bot commented Mar 20, 2024

🦋 Changeset detected

Latest commit: bb94f9a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/catalyst-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Mar 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 26, 2024 1:07pm
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) Visit Preview Mar 26, 2024 1:07pm
catalyst-au ⬜️ Ignored (Inspect) Visit Preview Mar 26, 2024 1:07pm
catalyst-storybook ⬜️ Ignored (Inspect) Visit Preview Mar 26, 2024 1:07pm
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Mar 26, 2024 1:07pm


type SubmitCustomerChangePassword = z.infer<typeof Input>;

const SUBMIT_CUSTOMER_CHANGE_PASSWORD_MUTATION = graphql(`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like we should match the mutation name. 🍹

}
`);

export const submitCustomerChangePassword = async ({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, I feel we should match the mutation name.

Copy link
Contributor

⚡️🏠 Lighthouse report

We ran Lighthouse against the changes and produced this report. Here's the summary:

Category Score
🟢 Performance 99
🟢 Accessibility 100
🟠 Best practices 78
🟢 SEO 92

Lighthouse ran against https://catalyst-latest-boajh25xo-bigcommerce-platform.vercel.app/

@bc-alexsaiannyi bc-alexsaiannyi added this pull request to the merge queue Mar 26, 2024
Merged via the queue into main with commit cfab55b Mar 26, 2024
11 checks passed
@bc-alexsaiannyi bc-alexsaiannyi deleted the mutation-customer-change-password branch March 26, 2024 13:11
This was referenced Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants